From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id A91E61F4B4 for ; Thu, 8 Apr 2021 13:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231641AbhDHNew (ORCPT ); Thu, 8 Apr 2021 09:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231566AbhDHNew (ORCPT ); Thu, 8 Apr 2021 09:34:52 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 328D8C061761 for ; Thu, 8 Apr 2021 06:34:41 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id w3so3094540ejc.4 for ; Thu, 08 Apr 2021 06:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oKOPWpE2w/9EGTt9O5g6SSmd9060c/UmgzyutjoR9HY=; b=FEtZt+xQ4lfMdPgReBwKHMW3kGDvxgmtTwCsLdfn0OmL5gnTUJjSkoki6RQ8kcs1J+ TcSrVjNoCP71p8Z6ys0r7pcQrbStExnJrdVWCBn6OuVhar/ZnFsfY3W07erFZPsJpvwx d9kH06t84yX8Df5I7fSRxkYbHMH1jm06exbJamkcEf/73k/ERH01W8rVHiywVnblXcTR qvkWVBHkr4kZ7BiFeexfVO2E0S73GocEFRB2iYj1cemDAFapaxbazznJDyuIbRhLQBdf PE8nPENwprxEQ/MWT5QCiV0ekajMWZxNC/lxxc1G1tHySarNw2KgG0zzv0iJbn2FC9Rc 7NCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oKOPWpE2w/9EGTt9O5g6SSmd9060c/UmgzyutjoR9HY=; b=GYHKVy3QmCUEyTTg2pdwGZvck1ZlEpuhYz+UEw3VdxQQZwb2RqGXTrOz+ySWTWDGmj ZrM+ZY+Dbq7lDb2aOUo1cTAJdT8O8iotsHQBot6I2Wa4Eu89HjGz185FP+sZmMhO3X11 jxKatYBnSuzd5eGqPZ2I8defqF/sIxVCKP18BSYC/tidBTKl3ji1gGylASA1jWLm38ot HM3uAr7jWxGprIv0jeNyAydHh9+FVr14TOUSw6kZsFnDUpg6SWN2x8ml9p9Hjllu/zQW cX5bsC5M+vuMK51YPoU0Mrgmdh42gXotf7rd1BmV9CVmDjI77PaGh/bSSI0gk/d5WK/B pl6w== X-Gm-Message-State: AOAM531LTm/SmJ05tLUMoaQChucxTgmsFNvb6589SUAA7oBZG7gVbqkm c5ZsNZLeNjm4oKb2KdTw8UcnsQhpMsCTVg== X-Google-Smtp-Source: ABdhPJxIcNCxqnBGxpJiuM/ipnV0sCV7c+/3ShFZ48MMZcmrYoKhabUPpPLfxxq93MGk+7MJ0LXPdw== X-Received: by 2002:a17:907:921:: with SMTP id au1mr10072302ejc.386.1617888879683; Thu, 08 Apr 2021 06:34:39 -0700 (PDT) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id x24sm12441621edr.36.2021.04.08.06.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 06:34:39 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Lin Sun , =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?= , David Aguilar , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH 1/5] config.c: add a comment about why value=NULL is true Date: Thu, 8 Apr 2021 15:34:25 +0200 Message-Id: X-Mailer: git-send-email 2.31.1.527.g9b8f7de2547 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org It's not very intuitive that git_parse_maybe_bool_text() would consider NULL to be a true value. Add a small comment about it. See a789ca70e7 (config: teach "git -c" to recognize an empty string, 2014-08-04) for the behavior of "git -c", but we'll end up here in both the config file parsing and command-line parsing cases. Signed-off-by: Ævar Arnfjörð Bjarmason --- config.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/config.c b/config.c index 6428393a41..fc28dbd97c 100644 --- a/config.c +++ b/config.c @@ -1229,6 +1229,10 @@ ssize_t git_config_ssize_t(const char *name, const char *value) static int git_parse_maybe_bool_text(const char *value) { if (!value) + /* + * "[foo]\nbar\n" and "-c foo.bar" on the command-line + * are true. + */ return 1; if (!*value) return 0; -- 2.31.1.527.g9b8f7de2547