git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH 1/4] doc lint: fix error-hiding regression
Date: Fri, 15 Oct 2021 14:39:11 +0200	[thread overview]
Message-ID: <patch-1.4-a6461f6e486-20211015T123619Z-avarab@gmail.com> (raw)
In-Reply-To: <cover-0.4-00000000000-20211015T123619Z-avarab@gmail.com>

Fix the broken "make lint-docs" (or "make check-docs" at the
top-level) target, which has been broken since my cafd9828e89 (doc
lint: lint and fix missing "GIT" end sections, 2021-04-09).

The CI for "seen" is emitting an error about a broken gitlink, but due
to there being 3x scripts chained via ";" instead of "&&" we're not
carrying forward the non-zero exit code.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Documentation/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index f5605b7767f..78324934d9f 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -461,9 +461,9 @@ lint-docs::
 		$(HOWTO_TXT) $(DOC_DEP_TXT) \
 		--section=1 $(MAN1_TXT) \
 		--section=5 $(MAN5_TXT) \
-		--section=7 $(MAN7_TXT); \
-	$(PERL_PATH) lint-man-end-blurb.perl $(MAN_TXT); \
-	$(PERL_PATH) lint-man-section-order.perl $(MAN_TXT);
+		--section=7 $(MAN7_TXT) && \
+	$(PERL_PATH) lint-man-end-blurb.perl $(MAN_TXT) && \
+	$(PERL_PATH) lint-man-section-order.perl $(MAN_TXT)
 
 ifeq ($(wildcard po/Makefile),po/Makefile)
 doc-l10n install-l10n::
-- 
2.33.1.1338.g20da966911a


  reply	other threads:[~2021-10-15 12:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 12:39 [PATCH 0/4] doc lint: fix recent regression, make non-.PHONY Ævar Arnfjörð Bjarmason
2021-10-15 12:39 ` Ævar Arnfjörð Bjarmason [this message]
2021-10-15 12:39 ` [PATCH 2/4] doc lint: emit errors on STDERR Ævar Arnfjörð Bjarmason
2021-10-15 12:39 ` [PATCH 3/4] doc build: speed up "make lint-docs" Ævar Arnfjörð Bjarmason
2021-10-15 17:21   ` Junio C Hamano
2021-10-15 12:39 ` [PATCH 4/4] doc lint: make "lint-docs" non-.PHONY Ævar Arnfjörð Bjarmason
2021-10-16  1:57   ` Bagas Sanjaya
2021-10-16  5:13     ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=patch-1.4-a6461f6e486-20211015T123619Z-avarab@gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).