* [PATCH] http.c: use error_errno(), not error() after fopen() failure
@ 2021-07-27 0:07 Ævar Arnfjörð Bjarmason
0 siblings, 0 replies; only message in thread
From: Ævar Arnfjörð Bjarmason @ 2021-07-27 0:07 UTC (permalink / raw)
To: git
Cc: Junio C Hamano, Jonathan Tan, Mike Hommey,
Ævar Arnfjörð Bjarmason
Improve the error reporting added in e929cd20bb3 (http.c: new
functions for the http API, 2009-06-06) to emit strerror(), as fopen()
is a failing system call we'll have a meaningful errno to report.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
http.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/http.c b/http.c
index 8119247149..f7940f1b5e 100644
--- a/http.c
+++ b/http.c
@@ -2341,8 +2341,8 @@ struct http_pack_request *new_direct_http_pack_request(
strbuf_addf(&preq->tmpfile, "%s.temp", sha1_pack_name(packed_git_hash));
preq->packfile = fopen(preq->tmpfile.buf, "a");
if (!preq->packfile) {
- error("Unable to open local file %s for pack",
- preq->tmpfile.buf);
+ error_errno("Unable to open local file %s for pack",
+ preq->tmpfile.buf);
goto abort;
}
--
2.32.0.988.g1a6a4b2c5f
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-27 0:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 0:07 [PATCH] http.c: use error_errno(), not error() after fopen() failure Ævar Arnfjörð Bjarmason
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).