From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=-11.4 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B04FD1F44D for ; Wed, 17 Apr 2024 23:08:25 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=kJGDfA0Y; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AA0FF1C2160E for ; Wed, 17 Apr 2024 23:08:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 38E968563C; Wed, 17 Apr 2024 23:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kJGDfA0Y" Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB13881ACC for ; Wed, 17 Apr 2024 23:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713395298; cv=none; b=Y5Src4/YQEHNG5OVg1ItGLl0Mx53IM4SI3E6M7waoGviwcPCF6LTbL9vuSYPGyIWAA27f2HsTx9qG/r1JJr5Su2QQlQGnUNsgvAK7vM6eef1t+XGmmGEhEJdHnSeZ8KJYCDjcF4T7Ap697vxWdEUC+fq9vDgO3c/2H8UszJTixg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713395298; c=relaxed/simple; bh=4aauvfeedGTCVobxYZ6ZfWYGXCWj0bvDoLZvgky97Ds=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oNEK8ajLuf2n9bR1Quk4r0BYEA7DRvsqpu9xBrTxqJdXpjSXsnJyrjHWtsvW3HWqRQ35qL1rQklx4RPPMwt8Qm0m8iehzCh1BzQMpyxWHRHXRVtP3+0MxJM1tVzsnTFZOoOdKnfjfBklO1ibhha5v9+hGT5CVPk22sTaXPSYUvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--linusa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kJGDfA0Y; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--linusa.bounces.google.com Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-6f041e39bc7so472848b3a.1 for ; Wed, 17 Apr 2024 16:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713395296; x=1714000096; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BmP4Y4yi7N00mS4qNAIHkBIG3h4iAd/CDyV+F5lcBAw=; b=kJGDfA0Y8QEKgXyBZPfpJuYLtwfM2IB2n7vbv9WPJZeaPWSCWzQls7uCfrhYoJrOvF B7bLAbx+SDcs6RBTDu14T2WLI2PspZClRVRwXCKxmqBJ+rBjLFwVzXXdD3DBB6wTEfRx jMjYNWZTjFhUiXP/BgHUBocRLWN88ZDKqeWeI1WfFEKNoPNtyP9bvMWCeNgg+xP6RXO9 XWNY/Sv/YHJIqaqXRu12SSrgOzQuAAg+KU9lmnSPJppTI0JN53ubL+U9NKUCSkfv3k7i 2QhCAjH4+wvAeGKQMD6yEZNxoLP3B2pPrVGAqbkm5b4HOkOA5EBptmM9dpkxys280EI7 Q/Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713395296; x=1714000096; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BmP4Y4yi7N00mS4qNAIHkBIG3h4iAd/CDyV+F5lcBAw=; b=rZedIsxKgkmlG4qUF0/ULjeDPFBjb8Y222Uye9TA7w+XY+BHCWuiGIVzy7jgMbQ06s fvcBAOwU4cJxLVXE6JWfZdQnoUkQ2GK7W4g0AHFdcsm/AxDqqczfNMG3ekqUORHYUiPs AnQUi/2jmPO7DSxJLSH+u9jortaloDuYAIFlZDnfFo4c2AJKsCmTMJ+AfVOg/QFcrGZj QlbqCc/Y/wBz4BB6pWwmVWnAEqNGFBstDEPnb32ySN+aF0dVVfIPcMgMuPWhMDKJUIzS sPLG2TXAaU3nIbU0VyS7gdlt3l6D2w0PTvdzSMgCLhfR54p6/QJT/Luqb+8di3YCE68v g0mA== X-Forwarded-Encrypted: i=1; AJvYcCV+3Zy/HMYXrEbqOhcTNjCmXC5o3JpSJsTWxET9XxXYyPbWcjkDmu+ptRxYjg2r+L7/Z2JGU0c8aatOt30cdxpo6lEk X-Gm-Message-State: AOJu0YyRvb2e2De+wZ1AozmGBimsUlf3Xb+0bymd1sbEGdKZJymOmd2F 24sDBagIOuXwIzo8NEDDawKZDkEtvOwiFnxPnlNuPKV8CoV/lmgNtsHM4jZdS9+0j3QTDCKBtZP +vg== X-Google-Smtp-Source: AGHT+IERGgjxSJ5MPx7bkBKLZPwncnTH/np0v+2k9zkjCM5+2UQFGEYltc765Kne5PQ21Cj4YenTA4JRkUc= X-Received: from fine.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:2221]) (user=linusa job=sendgmr) by 2002:a05:6a00:98f:b0:6ed:344:9faa with SMTP id u15-20020a056a00098f00b006ed03449faamr100103pfg.1.1713395295939; Wed, 17 Apr 2024 16:08:15 -0700 (PDT) Date: Wed, 17 Apr 2024 16:08:14 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: Message-ID: Subject: Re: [PATCH v4 2/8] SubmittingPatches: clarify 'git-contacts' location From: Linus Arver To: Junio C Hamano Cc: Linus Arver via GitGitGadget , git@vger.kernel.org, Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas Content-Type: text/plain; charset="UTF-8" Junio C Hamano writes: > Junio C Hamano writes: > >> We are not installing this thing (yet), so how about giving an >> instruction to run "perl contrib/contacts/git-contacts", only >> assuming that the user is intelligent enough to be able to react to >> "perl: not found" by installing it on their path? > > That is, something like this, perhaps. > > As the string given to --cc-cmd is stored in $cc_cmd, and is used in > this call: > > push @cc, recipients_cmd("cc-cmd", "cc", $cc_cmd, $t, $quiet) > > where recipients_cmd takes ($prefix, $what, $cmd, $file, $quiet) and > runs execute_cmd($prefix, $cmd, $file). execute_cmd in turn takes > ($prefix, $cmd, $file) and does this: > > open my $fh, "-|", "$cmd \Q$file\E" > or die sprintf(__("(%s) Could not execute '%s'"), $prefix, $cmd); > > IOW, $cmd is just an early part of a shell command line that takes a > filename as its last argument, so I think it would be fine for $cmd > to be "perl contrib/contacts/git-contacts". I did not test it, and > it would be appreciated if people can test it. I should be able to test this later this week.