git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: "Yngve N. Pettersen" <yngve@vivaldi.com>
To: git@vger.kernel.org
Subject: Git error message "Server does not allow request for unadvertised object"
Date: Mon, 18 May 2020 11:20:57 +0200	[thread overview]
Message-ID: <op.0ks2w7r1pvqxoc@rowan.vivaldi> (raw)

Hello all,

A while back I reported an issue to the Windows Git project  
<https://github.com/git-for-windows/git/issues/2218> that I observed in  
Git for Windows 2.21.

The error message "Server does not allow request for unadvertised object"  
is reported when a commit updating a submodule pointer points to a commit  
that does not exist in the repository for that submodule, even if later  
commits in the branch points to a commit that do exist in the submodule  
repo.

This circumstance can easily occur if a developer (e.g)

  * interactively rebases a branch "foo" in the submodule (e.g to integrate  
commits from another branch before a larger rebase)
  * commits the resulting submodule pointer "A" in the branch to the parent  
repo
  * then do further rebasing in the submodule, e.g to move up on top of the  
"bar" branch
  * commits that pointer "B" to the parent repo
  * forgets to squash the history in the parent repo
  * pushes the updated submodule "foo" branch to the online repo. (NOTE:  
"B" is pushed, not "A")
  * pushes the parent module branch to its online repo

When the parent repo is pulled by another developer, or an autobuild  
system, the fetch operation fails with the message "Server does not allow  
request for unadvertised object". A second fetch will complete  
successfully.

IMO this kind of check should only happen if a commit with pointer to a  
missing submodule is actively checked out. At most the above message  
should be a warning, not a fatal error.

For manual fetch operations this is mostly a nuisance, but for  
autobuilders this breaks the update operation, and the entire build  
operation fails. That is unacceptable behavior in an automatic system  
(errors if it breaks the checkout, yes; issues that are not relevant to  
the actual checkout, no).

This issue prevents upgrading past 2.17 (since 2.18 and 2.19 had other  
blocking issues, and 2.20 apparently introduced this issue). I have not  
tested 2.22+ since I have not noticed any changelog messages that seem  
related.

A test case can be found in issue 2218, linked above.

For reference, we do have a server-side git hook that verifies that  
submodule pointers for the production branch is correct and exists in the  
submodule's repo, and also is on branches that follows certain naming  
conventions.


As an aside, I think this kind of error message would be have been better  
suited as either a client-side push check, to prevent pushes of references  
to such missing commits (Smartgit seems to have something like it, but I  
think it only checks for the current branch in the submodule, not all  
submodule reference commits). Alternatively, there could be a check of  
this server-side.


Related to this, but not as problematic, just irritating, and also seen in  
2.17, is a message "warning: Submodule in commit deadbee at path: '(NULL)'  
collides with a submodule named the same. Skipping it." I think it is  
related to recreating a git modules file on a different branch.

-- 
Sincerely,
Yngve N. Pettersen
Vivaldi Technologies AS

             reply	other threads:[~2020-05-18  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18  9:20 Yngve N. Pettersen [this message]
2020-05-25 12:27 ` Philippe Blain
2020-09-06 12:47 ` Yngve N. Pettersen
2021-09-01 12:04   ` Yngve N. Pettersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.0ks2w7r1pvqxoc@rowan.vivaldi \
    --to=yngve@vivaldi.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).