From: Jan Engelhardt <jengelh@inai.de>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org, James Coglan <jcoglan@gmail.com>
Subject: Re: Misrendering of git 2.24 log --graph
Date: Fri, 24 Jan 2020 17:08:33 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2001241652250.32144@n3.vanv.qr> (raw)
In-Reply-To: <b64e8fb7-1dd3-439f-6ab1-1b88c52879d1@gmail.com>
On Friday 2020-01-24 15:05, Derrick Stolee wrote:
>> I have observed git 2.24 outputting a garbage graph element for a
>> particular history.
>
>I initially thought you were right, as 2.25 did include some new
>rendering, and we've already found and fixed a regression [1] and
>a style issue [2].
>[...]
>Here is something I noticed: this does not reproduce without a
>commit-graph! That's likely because it changes the order of the
>initial refs. Keep that in mind for anyone trying to repro this.
Curiously, I need no --mirror for `git clone`, the default clone
operation is just fine. It has, as far as I can remember back,
always downloaded all origin:refs/heads/* and refs/tags/*.
>However, I see this output with 2.24.1:
>| | | _
>| | * 79106b731 doc: update 8.7.x news
>
>and this output in 2.25.0 [...]
>
>Is it possible that you are not running the version you think you are?
I rerun my checks as I write this mail. The observations:
* Built v2.23.0 from source, ran it via `../tmpdir/git/git log --andsoon`,
shows said underscore.
* Built v2.24.0 from source, shows underscore
* Built v2.24.1 from source, shows underscore
* Used v2.24.1 from distro (/usr/bin/git), renders underscore
* Built ead10bacc466a409490fb743d7805893976f8f53 (most recent
branch join not having v2.25 as an ancestor) from src,
shows underscore
* Built v2.25.0 from source, new rendering
* Built 631a7dec11, same as v2.25.0
* Built 631a7dec11^, same as v2.25.0
prev parent reply other threads:[~2020-01-24 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 23:12 Misrendering of git 2.24 log --graph Jan Engelhardt
2020-01-24 14:05 ` Derrick Stolee
2020-01-24 14:06 ` Derrick Stolee
2020-01-24 16:34 ` Misrendering of git 2.25 " Jan Engelhardt
2020-01-24 18:45 ` Derrick Stolee
2020-01-24 21:26 ` SZEDER Gábor
2020-01-24 16:08 ` Jan Engelhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2001241652250.32144@n3.vanv.qr \
--to=jengelh@inai.de \
--cc=git@vger.kernel.org \
--cc=jcoglan@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).