Re: a problem with git describe

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi Junio,

On Sat, 23 Apr 2022, Junio C Hamano wrote:

> Philip Oakley <philipoakley@iee.email> writes:
>
> >> guy@renard ~/Software/uncrustify $ sudo git describe --always --dirty
> > ...
> > There has also been added an escape hatch of allowing "*" for the
> > permitted safe directories. but do check the updated manuals, and the
> > git mailing list archive (update the search in the above link).
>
> In this particular case, I do not think '*' is needed, but you need
> to be careful here.  Whose configuration are you suggesting to add
> such an entry?  Yourself?  ~root/.gitconfig?

One relatively simple work-around might be to call `sudo chown root .`
before running `sudo make install`, but of course this would require the
`rm -rf` to be run via `sudo`, too.

> I wonder if we should loosen "the same owner" check somewhat to
> cover this situation better.  I expect people also run the
> installation in repositories they own with "sudo make install",
> and complaining "euid does not own that repository" when it is
> merely because they are running as root (and their real identity
> is still in ruid) feels a bit too strict to be useful.

It's too bad that your fix to include euid seems not to work. That would
have been my preference.

Do we want to make use of the environment variable `SUDO_UID` that is set
by `sudo`?

Ciao,
Dscho