Re: [PATCH 4/6] builtin/stash: provide a way to export stashes to a ref

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

Hi brian,

On Wed, 16 Mar 2022, brian m. carlson wrote:

> On 2022-03-14 at 21:19:10, Phillip Wood wrote:
>
> > On 11/03/2022 02:08, Ævar Arnfjörð Bjarmason wrote:
> > >
> > > On Thu, Mar 10 2022, brian m. carlson wrote:
> > >
> > > > +			}
> > > > +			snprintf(buf, sizeof(buf), "%zu", i);
> > >
> > > Aren't the %z formats unportable (even with our newly found reliance on
> > > more C99)? I vaguely recall trying them recently and the windows CI jobs
> > > erroring...
> >
> > According to [1] it has been available since at least 2015. It is certainly
> > much nicer than casting every size_t to uintmax_t and having to use PRIuMAX.
>
> If we're relying on a new enough MSVC for C11, then it's much newer than
> 2015, so we should be fine.  It's mandatory on POSIX systems.

The MSVCRT we're using in GCC is much, much older, and that won't change
anytime soon, I don't think.

You _might_ get the code to compile a `%zu` format by playing some macro
tricks, but executing the result would still not work.

It sure would be nice if we could use all that POSIX promises... but we
can't. Sorry...

Ciao,
Dscho