Hi,


On Mon, 21 Feb 2022, Ævar Arnfjörð Bjarmason wrote:

> Remove Azure-specific code that's been unused since 6081d3898fe (ci:
> retire the Azure Pipelines definition, 2020-04-11). As noted in a
> larger removal of all of the Azure-supporting code in [1] (although
> that missed some of this) there is more of it in-tree, but let's focus
> on only the ci/* code for now.
>
> This is needed because in subsequent commits this unused code would
> either need to be changed to accommodate changes in ci/*, or be
> removed.
>
> As we'll see in those subsequent commits the end-state we're heading
> towards will actually make it easier to add new CI types in the
> future, even though the only one we're left with now is the GitHub
> CI. I.e. the "ci/*" framework will be made to do less, not more. We'll
> be offloading more of what it does to our generic build and test
> system.
>
> While I'm at it (since the line needs to be touched anyway) change an
> odd 'if test true == "$GITHUB_ACTIONS"' to the more usual style used
> in other places of 'if test "$GITHUB_ACTIONS" = "true"'.
>
> 1. https://lore.kernel.org/git/patch-1.1-eec0a8c3164-20211217T000418Z-avarab@gmail.com/

This has been discussed before, and I already gave my NAK.

It is sad that I have to repeat myself: it is a good thing to have the
Azure Pipelines definition as a fall-back. In the past, this has served us
very well especially when we had to run a barrage of security fixes, for a
slew of backports to previous release trains.

You seem to have fun to just remove this code, under some assumption that
it is not needed, despite me pointing out that it is needed.

Ciao,
Johannes