From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, reiter.christoph@gmail.com,
"Matthias Aßhauer" <mha1993@live.de>,
"Matthias Aßhauer via GitGitGadget" <gitgitgadget@gmail.com>
Subject: Re: [PATCH] lazyload: use correct calling conventions
Date: Tue, 11 Jan 2022 14:17:39 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2201111412300.1081@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqh7abxmxs.fsf@gitster.g>
Hi Junio,
On Mon, 10 Jan 2022, Junio C Hamano wrote:
> Dscho, how does this look? My choices are
>
> - Waiting for review.
> - Will merge to 'next'.
> - Will merge to 'next' and then to 'master'.
My preference is the last option, merge it down quickly.
> The last one will make it as part of Git 2.35.0 final, unless there
> is some unexpected breakage found later.
I do not expect anything to break. Just like Matthias, I actually expect
future breakages to be fended off by this.
Merging it into v2.35.0 final will require a tiny fixup in
`compat/win32/flush.c` (which we carry in Git for Windows already), but
that's a much smaller deal than the fall-out of the v2.34.0 refactorings
we had to deal with.
Thank you,
Dscho
next prev parent reply other threads:[~2022-01-11 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 16:02 [PATCH] lazyload: use correct calling conventions Matthias Aßhauer via GitGitGadget
2022-01-10 22:09 ` Junio C Hamano
2022-01-11 13:17 ` Johannes Schindelin [this message]
2022-01-11 22:33 ` Johannes Schindelin
2022-01-12 18:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2201111412300.1081@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=mha1993@live.de \
--cc=reiter.christoph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).