Re: [PATCH v4] subtree: fix argument handling in check_parents

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi James,

On Wed, 8 Dec 2021, James Limbouris via GitGitGadget wrote:

> From: James Limbouris <james@digitalmatter.com>
>
> 315a84f9aa0 (subtree: use commits before rejoins for splits, 2018-09-28)
> changed the signature of check_parents from 'check_parents [REV...]'
> to 'check_parents PARENTS_EXPR INDENT'. In other words the variable list
> of parent revisions became a list embedded in a string. However it
> neglected to unpack the list again before sending it to cache_miss,
> leading to incorrect calls whenever more than one parent was present.
> This is the case whenever a merge commit is processed, with the end
> result being a loss of performance from unecessary rechecks.
>
> The indent parameter was subsequently removed in e9525a8a029 (subtree:
> have $indent actually affect indentation, 2021-04-27), but the argument
> handling bug remained.
>
> For consistency, take multiple arguments in check_parents,
> and pass all of them to cache_miss separately.
>
> Signed-off-by: James Limbouris <james@digitalmatter.com>
> ---
>     subtree: fix argument handling in check_parents
>
>     > I saw that you sent a v3, but did not see any of this information
>     > (which took a good while to assemble, as you might have guessed) in
>     > the commit message. However, I think that message would make for the
>     > best home for this information.
>
>     Sorry Dscho - it wasn't 100% clear to me which details were required.
>     I've rerolled and tried again. Also sorry if I'm not replying to the
>     mail correctly - I'm not actually subscribed to the list, and this seems
>     like the only easy way to get text onto it through gitgitgadget without
>     fighting Outlook.

It is not Outlook you're fighting. It is the decision by the majordomo of
the Git mailing list to drop @outlook.com and @hotmail.com mails. Because
who would use those email addresses, amirite?

In any case, thank you so much for sending the fixed commit, and sorry for
not reviewing it earlier. It looks good to me! With this commit message, I
think it is good to go.

Thanks,
Dscho