git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] completion: add human and auto: date format
@ 2021-11-23 11:27 Yoichi NAKAYAMA via GitGitGadget
  2021-11-25 11:45 ` Johannes Schindelin
  0 siblings, 1 reply; 2+ messages in thread
From: Yoichi NAKAYAMA via GitGitGadget @ 2021-11-23 11:27 UTC (permalink / raw)
  To: git; +Cc: Yoichi NAKAYAMA, Yoichi Nakayama

From: Yoichi Nakayama <yoichi.nakayama@gmail.com>

human was introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc
auto:* was introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182

Those formats were missing when other values were added to completion
at 5a59a2301f6ec9bcf1b101edb9ca33beb465842f

Signed-off-by: Yoichi Nakayama <yoichi.nakayama@gmail.com>
---
    completion: add human and auto: date format
    
    In bash/zsh completion for git log --date=, following values are
    missing:
    
     * human (introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc)
     * auto:* (introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182)
    
    They did exist when other values were added to completion at
    5a59a2301f6ec9bcf1b101edb9ca33beb465842f

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1083%2Fyoichi%2Flog-date-completion-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1083/yoichi/log-date-completion-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1083

 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 7c3a75373a4..37fd5c4c885 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2001,7 +2001,7 @@ __git_log_shortlog_options="
 "
 
 __git_log_pretty_formats="oneline short medium full fuller reference email raw format: tformat: mboxrd"
-__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default raw unix format:"
+__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default human raw unix auto: format:"
 
 _git_log ()
 {

base-commit: 0ea906d20517145895193a99666d5f2860a04360
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] completion: add human and auto: date format
  2021-11-23 11:27 [PATCH] completion: add human and auto: date format Yoichi NAKAYAMA via GitGitGadget
@ 2021-11-25 11:45 ` Johannes Schindelin
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2021-11-25 11:45 UTC (permalink / raw)
  To: Yoichi NAKAYAMA via GitGitGadget; +Cc: git, Yoichi NAKAYAMA, Yoichi Nakayama

Hi Yoichi,

On Tue, 23 Nov 2021, Yoichi NAKAYAMA via GitGitGadget wrote:

> From: Yoichi Nakayama <yoichi.nakayama@gmail.com>
>
> human was introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc
> auto:* was introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182
>
> Those formats were missing when other values were added to completion
> at 5a59a2301f6ec9bcf1b101edb9ca33beb465842f
>
> Signed-off-by: Yoichi Nakayama <yoichi.nakayama@gmail.com>

The commit message and the patch look good to me.

Thanks!
Dscho

> ---
>     completion: add human and auto: date format
>
>     In bash/zsh completion for git log --date=, following values are
>     missing:
>
>      * human (introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc)
>      * auto:* (introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182)
>
>     They did exist when other values were added to completion at
>     5a59a2301f6ec9bcf1b101edb9ca33beb465842f
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1083%2Fyoichi%2Flog-date-completion-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1083/yoichi/log-date-completion-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1083
>
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 7c3a75373a4..37fd5c4c885 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2001,7 +2001,7 @@ __git_log_shortlog_options="
>  "
>
>  __git_log_pretty_formats="oneline short medium full fuller reference email raw format: tformat: mboxrd"
> -__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default raw unix format:"
> +__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default human raw unix auto: format:"
>
>  _git_log ()
>  {
>
> base-commit: 0ea906d20517145895193a99666d5f2860a04360
> --
> gitgitgadget
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-25 11:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 11:27 [PATCH] completion: add human and auto: date format Yoichi NAKAYAMA via GitGitGadget
2021-11-25 11:45 ` Johannes Schindelin

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).