git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Yoichi NAKAYAMA via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Yoichi NAKAYAMA <yoichi.nakayama@gmail.com>,
	Yoichi Nakayama <yoichi.nakayama@gmail.com>
Subject: Re: [PATCH] completion: add human and auto: date format
Date: Thu, 25 Nov 2021 12:45:45 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2111251245200.63@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <pull.1083.git.1637666875171.gitgitgadget@gmail.com>

Hi Yoichi,

On Tue, 23 Nov 2021, Yoichi NAKAYAMA via GitGitGadget wrote:

> From: Yoichi Nakayama <yoichi.nakayama@gmail.com>
>
> human was introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc
> auto:* was introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182
>
> Those formats were missing when other values were added to completion
> at 5a59a2301f6ec9bcf1b101edb9ca33beb465842f
>
> Signed-off-by: Yoichi Nakayama <yoichi.nakayama@gmail.com>

The commit message and the patch look good to me.

Thanks!
Dscho

> ---
>     completion: add human and auto: date format
>
>     In bash/zsh completion for git log --date=, following values are
>     missing:
>
>      * human (introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc)
>      * auto:* (introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182)
>
>     They did exist when other values were added to completion at
>     5a59a2301f6ec9bcf1b101edb9ca33beb465842f
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1083%2Fyoichi%2Flog-date-completion-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1083/yoichi/log-date-completion-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1083
>
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 7c3a75373a4..37fd5c4c885 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2001,7 +2001,7 @@ __git_log_shortlog_options="
>  "
>
>  __git_log_pretty_formats="oneline short medium full fuller reference email raw format: tformat: mboxrd"
> -__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default raw unix format:"
> +__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default human raw unix auto: format:"
>
>  _git_log ()
>  {
>
> base-commit: 0ea906d20517145895193a99666d5f2860a04360
> --
> gitgitgadget
>

      reply	other threads:[~2021-11-25 11:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 11:27 [PATCH] completion: add human and auto: date format Yoichi NAKAYAMA via GitGitGadget
2021-11-25 11:45 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.2111251245200.63@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=yoichi.nakayama@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).