From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Carlo Arenas <carenas@gmail.com>,
git@vger.kernel.org, phillip.wood123@gmail.com,
thomas.wolf@paranor.ch, Alexander Veit <alexander.veit@gmx.net>
Subject: Re: [PATCH] editor: only save (and restore) the terminal if using a tty
Date: Wed, 24 Nov 2021 14:29:29 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2111241428190.63@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqtug293ml.fsf@gitster.g>
Hi,
On Tue, 23 Nov 2021, Junio C Hamano wrote:
> Carlo Arenas <carenas@gmail.com> writes:
>
> > yes, my plan was to minimize the impact of this bugfix by doing this
> > as narrow as possible, but you are correct that if we consider that
> > ...
> > I should have mentioned though that a better fix was forthcoming, just
> > not with so little time before 2.34.1 gets released.
> > ...
> >> In any case, I am quite tempted to just revert the offending topic
> >> for now, but later accept a resurrection patch with this isatty
> >> check rolled in (either at this caller, or inside save_term) when
> >> the dust settles.
> >
> > I indeed suggested[1] a revert but I wouldn't have proposed this
> > alternative if it wouldn't be done safely enough,
>
> I think the minimum impact fix is to revert the whole thing (people
> survived without it for long time), so that is what 2.34.1 will
> hopefully have. As I said elsewhere, I am open to a rebooted effort
> for the future cycles, but the conclusion for the topic in 2.34 series
> is that we pretend we never heard about it ;-)
Maybe a better approach would be to hide the `save_term()` dance behind a
new config option, and then have it turned on automatically if the
`editor` _happens_ to be `vi` or `vim`.
That would help the problem reported in the Windows Terminal project.
Ciao,
Dscho
next prev parent reply other threads:[~2021-11-24 13:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 8:42 Update to Git 2.34.0 breaks application Alexander Veit
2021-11-22 21:43 ` Phillip Wood
2021-11-22 22:28 ` [PATCH] editor: only save (and restore) the terminal if using a tty Carlo Marcelo Arenas Belón
2021-11-22 22:47 ` Junio C Hamano
2021-11-22 23:03 ` Junio C Hamano
2021-11-22 23:08 ` Junio C Hamano
2021-11-23 8:52 ` Alexander Veit
2021-11-23 9:08 ` Carlo Arenas
2021-11-22 23:39 ` Carlo Arenas
2021-11-23 17:35 ` Junio C Hamano
2021-11-24 13:29 ` Johannes Schindelin [this message]
2021-11-24 18:25 ` Carlo Arenas
2021-11-24 19:34 ` Junio C Hamano
2021-11-24 20:04 ` Carlo Arenas
2021-11-24 20:51 ` Junio C Hamano
2021-11-29 21:12 ` Johannes Schindelin
2021-11-23 11:05 ` Phillip Wood
2021-11-23 17:27 ` Junio C Hamano
2021-11-23 17:31 ` Carlo Arenas
2021-11-30 11:07 ` Phillip Wood
2021-12-01 5:12 ` Chris Torek
2021-12-01 19:33 ` Junio C Hamano
2021-12-02 0:38 ` Junio C Hamano
2021-12-02 1:51 ` Carlo Arenas
2021-12-02 14:48 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2111241428190.63@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=alexander.veit@gmx.net \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
--cc=thomas.wolf@paranor.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).