From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH v2] ci: disallow directional formatting
Date: Thu, 4 Nov 2021 11:19:08 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2111041111570.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqk0ho4xo5.fsf@gitster.g>
Hi Junio,
On Wed, 3 Nov 2021, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > +# U+202a..U+2a2e: LRE, RLE, PDF, LRO and RLO
> > +# U+2066..U+2069: LRI, RLI, FSI and PDI
> > +regex='(\u202a|\u202b|\u202c|\u202d|\u202e|\u2066|\u2067|\u2068|\u2069)'
> > +
> > +! git ls-files -z ':(attr:!binary)' |
> > +LC_CTYPE=C xargs -0r git grep -Ele "$(LC_CTYPE=C.UTF-8 printf "$regex")" --
>
> One thing for the future, and one thing for the present.
>
> - Do some languages we would add to po/ hierarchy in the future
> possibly want to use these sequences as legitimate contents?
I mulled over that. And I think you're right. If a right-to-left
translation needs to refer to, say, a `git` invocation, the part that
shows the commandline surely would need to be guarded within directional
formatting code points. We currently only have translated messages that
read left-to-right, for example we lack Arabic and Hebrew translations.
Those would be likely to contain such code points on purpose.
I therefore added `:(exclude)*.po` to the command.
> - Do we need ls-files?
>
>
> For the latter, shouldn't the attribute-based pathspec work just
> fine with "git grep"? i.e.
>
> git grep -l -E -e $pattern -- ':(exclude,attr:binary)'
D'oh. You're right! I fixed it.
Ciao,
Dscho
next prev parent reply other threads:[~2021-11-04 10:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 12:58 [PATCH] ci: disallow directional formatting Johannes Schindelin via GitGitGadget
2021-11-02 15:01 ` Ævar Arnfjörð Bjarmason
2021-11-02 15:48 ` Taylor Blau
2021-11-02 16:03 ` Ævar Arnfjörð Bjarmason
2021-11-02 16:12 ` Johannes Schindelin
2021-11-02 16:38 ` Ævar Arnfjörð Bjarmason
2021-11-03 17:20 ` Junio C Hamano
2021-11-03 12:23 ` [PATCH v2] " Johannes Schindelin via GitGitGadget
2021-11-03 16:36 ` Ævar Arnfjörð Bjarmason
2021-11-03 18:00 ` Junio C Hamano
2021-11-03 23:38 ` Junio C Hamano
2021-11-04 10:19 ` Johannes Schindelin [this message]
2021-11-04 13:13 ` [PATCH v3] " Johannes Schindelin via GitGitGadget
2021-11-04 13:48 ` Ævar Arnfjörð Bjarmason
2021-11-04 17:19 ` Junio C Hamano
2021-11-08 18:49 ` Ævar Arnfjörð Bjarmason
2021-11-08 20:08 ` Junio C Hamano
2021-11-09 13:34 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2111041111570.56@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).