Re: [PATCH v3 0/8] Allow clean/smudge filters to handle huge files in the LLP64 data model

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi Junio,

On Fri, 29 Oct 2021, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > This patch series came in via the Git for Windows fork
> > [https://github.com/git-for-windows/git/pull/3487], and I intend to merge it
> > before v2.34.0-rc0, therefore I appreciate every careful review you gentle
> > people can spare.
>
> It is way too late for my tree to go in before -rc0,

As I said, the intention was to merge this into Git _for Windows_ before
-rc0. And I did. The non-Windows platforms are much less likely to benefit
from this patch series.

> but the patches in the last round, with the "Changes since v2"
> description below, all sound sensible, including the decision to stop
> here, instead of doing "everything should be either size_t or intmax_t"
> conversion.

Yep, if you want to weep, you can have a look at
https://github.com/git-for-windows/git/pull/2179/files, which tries to do
that `unsigned long` -> `size_t` thing (although admittedly in an as yet
unreviewable shape).

> 7/8 did not apply for me to the tip of 'master', but "am -3" wiggled
> it in.  You may want to double check the results.

The range-diff looks good.

> As the primary author of the series, given the cover title matches
> the title of one step in the series, seems to be Matt, let me queue
> them under mc/clean-smudge-with-llp64 topic.

Yep, this came in via Git for Windows, traditionally I take it upon me
to shepherd those contributions into upstream Git.

Ciao,
Dscho