From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Makefile: remove redundant GIT-CFLAGS dependency from "sparse"
Date: Fri, 22 Oct 2021 16:30:08 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2110221628190.62@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <patch-1.1-207f1019e70-20211021T195940Z-avarab@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]
Hi Ævar,
On Thu, 21 Oct 2021, Ævar Arnfjörð Bjarmason wrote:
> The "sparse" target needed the GIT-CFLAGS dependency before my
> c234e8a0ecf (Makefile: make the "sparse" target non-.PHONY,
> 2021-09-23), but since then it depends on the corresponding *.o files,
> which in turn depend on the correct header files, as well as on
> GIT-CFLAGS. There's no need to re-state this dependency here.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> A tiny redundancy fix for an already-in-master topic.
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 381bed2c1d2..12be39ac497 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2901,7 +2901,7 @@ check-sha1:: t/helper/test-tool$X
>
> SP_OBJ = $(patsubst %.o,%.sp,$(C_OBJ))
>
> -$(SP_OBJ): %.sp: %.c %.o GIT-CFLAGS
> +$(SP_OBJ): %.sp: %.c %.o
I _guess_ you could say that the `GIT-CFLAGS` dependency is redundant by
virtue of the `*.o` targets already depending on it.
But then, how much does it hurt? This late in the v2.34 cycle, aren't
there any issues that might be worthier of our attention and care?
Ciao,
Dscho
> $(QUIET_SP)cgcc -no-compile $(ALL_CFLAGS) $(EXTRA_CPPFLAGS) \
> -Wsparse-error \
> $(SPARSE_FLAGS) $(SP_EXTRA_FLAGS) $< && \
> --
> 2.33.1.1494.g88b39a443e1
>
>
prev parent reply other threads:[~2021-10-22 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 20:00 [PATCH] Makefile: remove redundant GIT-CFLAGS dependency from "sparse" Ævar Arnfjörð Bjarmason
2021-10-22 14:30 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2110221628190.62@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).