From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Miriam Rubio <mirucam@gmail.com>
Subject: Re: mr/bisect-in-c-4, was Re: What's cooking in git.git (Sep 2021, #02; Wed, 8)
Date: Fri, 10 Sep 2021 11:33:10 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2109101132460.59@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqr1dxuigf.fsf@gitster.g>
Hi Junio,
On Thu, 9 Sep 2021, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Wed, 8 Sep 2021, Junio C Hamano wrote:
> >
> >> * mr/bisect-in-c-4 (2021-09-02) 6 commits
> >> - bisect--helper: retire `--bisect-next-check` subcommand
> >> - bisect--helper: reimplement `bisect_run` shell
> >> - bisect--helper: reimplement `bisect_visualize()`shell function in C
> >> - run-command: make `exists_in_PATH()` non-static
> >> - t6030-bisect-porcelain: add test for bisect visualize
> >> - t6030-bisect-porcelain: add tests to control bisect run exit cases
> >>
> >> Rewrite of "git bisect" in C continues.
> >
> > From my point of view, this is ready for `next`.
>
> You agreed that redirection with dup2()'s in [5/6] was good enough
> for now [*1*], but in that case, we need to add a few fflush(stdout)
> around the dup2() dance [*2*].
>
> So this is not quite ready for 'next' yet, although it is almost
> there, I'd think.
Oh right, I fogot about the `fflush()` stuff.
Thanks,
Dscho
>
>
> [References]
>
> *1* https://lore.kernel.org/git/nycvar.QRO.7.76.6.2109090922310.55@tvgsbejvaqbjf.bet/
>
> *2* https://lore.kernel.org/git/xmqqtuj2h7cp.fsf@gitster.g/
>
next prev parent reply other threads:[~2021-09-10 9:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 15:38 What's cooking in git.git (Sep 2021, #02; Wed, 8) Junio C Hamano
2021-09-08 16:24 ` Taylor Blau
2021-09-08 19:23 ` Junio C Hamano
2021-09-09 1:02 ` Taylor Blau
2021-09-08 21:27 ` Jeff King
2021-09-08 16:55 ` Azeem Bande-Ali
2021-09-08 19:20 ` Junio C Hamano
2021-09-08 17:50 ` Philippe Blain
2021-09-08 21:57 ` Derrick Stolee
2021-09-09 14:23 ` Elijah Newren
2021-09-09 2:59 ` Ramsay Jones
2021-09-09 17:45 ` Junio C Hamano
2021-09-09 11:03 ` js/scalar, was " Johannes Schindelin
2021-09-10 8:52 ` Junio C Hamano
2021-09-09 11:05 ` rs/range-diff-avoid-segfault-with-I, " Johannes Schindelin
2021-09-09 11:08 ` js/retire-preserve-merges, " Johannes Schindelin
2021-09-10 5:00 ` Junio C Hamano
2021-09-09 11:08 ` mr/bisect-in-c-4, " Johannes Schindelin
2021-09-10 5:07 ` Junio C Hamano
2021-09-10 9:33 ` Johannes Schindelin [this message]
2021-09-09 11:13 ` lh/systemd-timers, " Johannes Schindelin
2021-09-09 11:15 ` ar/submodule-add-more, " Johannes Schindelin
2021-09-10 5:30 ` Junio C Hamano
2021-09-09 11:18 ` Ævar Arnfjörð Bjarmason
2021-09-09 14:12 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2109101132460.59@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mirucam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).