git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
	Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] tests: remove leftover untracked files
Date: Wed, 8 Sep 2021 09:53:18 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2109080950540.55@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <pull.1088.git.git.1631076472457.gitgitgadget@gmail.com>

Hi Elijah,

On Wed, 8 Sep 2021, Elijah Newren via GitGitGadget wrote:

> From: Elijah Newren <newren@gmail.com>
>
> Remove untracked files that are unwanted after they are done being used.
>
> While the set of cases in this patch is certainly far from
> comprehensive, it was motivated by some work to see what the fallout
> would be if we were to make the removal of untracked files as a side
> effect of other commands into an error.  Some cases were a bit more
> involved than the testcase changes included in this patch, but the ones
> included here represent the simple cases.  While this patch is not that
> important since we are not changing the behavior of those other commands
> into an error in the near term, I thought these changes were useful
> anyway as an explicit documentation of the intent that these untracked
> files are no longer useful.

While I find it a bit distracting when things are getting fixed that are
not exactly broken (there is enough that is broken and needs to be
fixed!), at least this patch is not disruptive and since you already did
the work, I am in favor of integrating the patch.

Thanks,
Dscho

  reply	other threads:[~2021-09-08  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  4:47 [PATCH] tests: remove leftover untracked files Elijah Newren via GitGitGadget
2021-09-08  7:53 ` Johannes Schindelin [this message]
2021-09-08 13:11 ` Derrick Stolee
2021-09-11 17:08 ` [PATCH v2] " Elijah Newren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.2109080950540.55@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).