From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
git@vger.kernel.org, "Emily Shaffer" <emilyshaffer@google.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH] make: add INSTALL_STRIP variable
Date: Tue, 24 Aug 2021 11:49:25 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2108241148560.55@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <6e0ef7f2-3dd0-09e4-5a1d-7e59b979d624@gmail.com>
Hi Bagas,
On Tue, 24 Aug 2021, Bagas Sanjaya wrote:
> On 23/08/21 22.55, Junio C Hamano wrote:
> > Perhaps. One bad thing with the current "strip" arrangement is that
> > it is done in the built directory, and because "make install" would
> > blindly install whatever in the built directory, if you truly care
> > that you install unstripped binaries, you need to see if they are
> > stripped and rebuild them as needed, because "make strip" may or may
> > not have been done. From that point of view, getting rid of the
> > current "make strip" and introducing either "make strip-installed"
> > ("we've installed things earlier---go strip them") or "make
> > install-stripped" ("we've built (or if we haven't please build them
> > first), now install them and strip them in the installed directory")
> > may make more sense. And for that, any idea that came up in this
> > discussion that relies on the current "strip" target would not help.
>
> But often the installed directory (install prefix) is owned by root,
> so one has to `sudo make install-strip`, right?
The default for `make install` goes to `$HOME`. I would wager a bet that
that's the common case, too. It does not require `sudo`.
Ciao,
Dscho
next prev parent reply other threads:[~2021-08-24 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 10:50 [PATCH] make: add INSTALL_STRIP variable Bagas Sanjaya
2021-08-20 11:36 ` Đoàn Trần Công Danh
2021-08-20 18:16 ` Junio C Hamano
2021-08-21 2:13 ` Đoàn Trần Công Danh
2021-08-23 15:55 ` Junio C Hamano
2021-08-24 9:39 ` Bagas Sanjaya
2021-08-24 9:49 ` Johannes Schindelin [this message]
2021-08-24 18:58 ` Junio C Hamano
2021-08-21 8:24 ` Bagas Sanjaya
2021-08-21 10:35 ` Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2108241148560.55@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=bagasdotme@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).