From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
ak@linux.intel.com, "Jeff Hostetler" <git@jeffhostetler.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] make: add install-strip target
Date: Tue, 17 Aug 2021 23:28:37 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2108172327290.55@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20210817110728.55842-1-bagasdotme@gmail.com>
Hi Bagas,
On Tue, 17 Aug 2021, Bagas Sanjaya wrote:
> diff --git a/Makefile b/Makefile
> index 9573190f1d..8c4633ba8e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3093,6 +3093,9 @@ endif
> done && \
> ./check_bindir "z$$bindir" "z$$execdir" "$$bindir/git-add$X"
>
> +install-strip: all strip
Would those `all` and `strip` targets interfere with one another if `make
-j2` was called? If not, wouldn't it be sufficient to let `install-strip`
depend on `strip` alone?
Ciao,
Dscho
> + $(MAKE) install
> +
> .PHONY: install-gitweb install-doc install-man install-man-perl install-html install-info install-pdf
> .PHONY: quick-install-doc quick-install-man quick-install-html
> install-gitweb:
> @@ -3265,7 +3268,7 @@ ifdef MSVC
> $(RM) compat/vcbuild/MSVC-DEFS-GEN
> endif
>
> -.PHONY: all install profile-clean cocciclean clean strip
> +.PHONY: all install install-strip profile-clean cocciclean clean strip
> .PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell
> .PHONY: FORCE cscope
>
>
> base-commit: 225bc32a989d7a22fa6addafd4ce7dcd04675dbf
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-08-17 21:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 11:07 [PATCH] make: add install-strip target Bagas Sanjaya
2021-08-17 21:28 ` Johannes Schindelin [this message]
2021-08-17 21:48 ` Eric Sunshine
2021-08-18 10:25 ` Johannes Schindelin
2021-08-19 19:54 ` Junio C Hamano
2021-08-24 13:15 ` Johannes Schindelin
2021-08-17 22:13 ` Junio C Hamano
2021-08-18 10:30 ` Johannes Schindelin
2021-08-19 19:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2108172327290.55@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=ak@linux.intel.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).