From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Subject: Re: [PATCH] ci: run `make sparse` as a GitHub workflow
Date: Thu, 15 Jul 2021 00:03:52 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2107142350570.59@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqa6movcly.fsf@gitster.g>
Hi Junio,
On Wed, 14 Jul 2021, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Wed, 14 Jul 2021, Junio C Hamano wrote:
> >
> >> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >>
> >> > Which means that the likelihood of a run to fail increases with the number
> >> > of jobs in said run (even innocuous problems such as transient failures to
> >> > download an Ubuntu package), and it also makes it much more painful to
> >> > re-run the entire thing because you may well end up wasting a grand total
> >> > of ~370 minutes even if only a 30-second-job would need to be re-run.
> >> >
> >> > Having said that, I think you're right and the upside of keeping things
> >> > together may outweigh that downside.
> >>
> >> I wasn't make a request or a demand to change or not to change
> >> anything, so in this particular exchange there was no point where I
> >> was right (or wrong, for that matter ;-). I was asking if there was
> >> a solid reasoning behind the split, and if there is, I am perfectly
> >> happy to see it done as a separate workflow with the log message
> >> that explains why it is separate. I am also perfectly fine with
> >> this rolled into the primary one, with clear reasoning behind the
> >> choice recorded in the log message.
> >
> > I do not think that it would be an improvement to defend the default
> > choice (i.e. to add this new job to `.github/workflows/main.yml`) in the
> > commit message. It is the default for new CI stuff to go, after all, and
> > we do not need to clutter the message by stating the obvious.
>
> It wasn't quite obvious why we justify spending 370 minutes one more
> time only to rerun 30-second job, though.
True.
And this is not a new problem. Every time anything happens in those
`osx-gcc` or `osx-clang` jobs (e.g. that transient problem with the broken
pipes in t5516 [*1*], that's a fun one), a full re-run is necessary, or
else the commit and/or PR will remain marked as broken.
In other words, while it is totally appropriate for me to explain this to
you in this here thread because it came up as a tangent, it would be
inappropriate to stick that explanation into this patch's commit message.
We do not make a habit of adding tangents that came up during patch
reviews into commit messages, and I do not intend to start such a habit
here, either.
Ciao,
Dscho
Footnote *1*: See
https://lore.kernel.org/git/20190829143805.GB1746@sigill.intra.peff.net/
(I don't think this is fixed as of now)
next prev parent reply other threads:[~2021-07-14 22:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 11:51 [PATCH] ci: run `make sparse` as a GitHub workflow Johannes Schindelin via GitGitGadget
2021-07-13 16:55 ` Đoàn Trần Công Danh
2021-07-14 9:12 ` Johannes Schindelin
2021-07-13 17:34 ` Philippe Blain
2021-07-14 9:09 ` Johannes Schindelin
2021-07-14 10:13 ` Johannes Schindelin
2021-07-16 1:37 ` Ramsay Jones
2021-07-13 22:41 ` Junio C Hamano
2021-07-14 10:09 ` Johannes Schindelin
2021-07-14 16:00 ` Junio C Hamano
2021-07-14 20:54 ` Johannes Schindelin
2021-07-14 20:56 ` Junio C Hamano
2021-07-14 22:03 ` Johannes Schindelin [this message]
2021-07-14 22:27 ` Junio C Hamano
2021-07-16 15:25 ` Johannes Schindelin
2021-07-16 16:42 ` Junio C Hamano
2021-07-14 11:50 ` [PATCH v2] ci: run `make sparse` as part of the " Johannes Schindelin via GitGitGadget
2021-07-26 17:53 ` [PATCH] ci: run "apt-get update" before "apt-get install" Jeff King
2021-07-26 18:22 ` Jeff King
2021-07-26 22:12 ` Junio C Hamano
2021-07-26 20:27 ` [PATCH v3] ci: run `make sparse` as part of the GitHub workflow Johannes Schindelin via GitGitGadget
2021-07-26 22:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2107142350570.59@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).