From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Derrick Stolee <stolee@gmail.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] t/perf worktree improvements
Date: Mon, 1 Mar 2021 23:03:08 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2103012302490.57@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <d6edd2e2-a1ae-bdef-7e6e-7c1984903a49@gmail.com>
Hi,
On Fri, 26 Feb 2021, Derrick Stolee wrote:
> On 2/26/2021 2:09 AM, Jeff King wrote:
> > I don't think v1 of this patch got picked up at all, so here it is
> > again. There was a question of whether we could do the much simpler
> > solution discussed in:
> >
> > https://lore.kernel.org/git/22378ce3-6845-1cd9-996a-8bdc3a8b65d7@gmail.com/
> >
> > But I think it would be confusing. So patch 1 is unchanged here from v1.
> >
> > Johannes suggested we could add some extra protections to avoid
> > accidentally modifying the original repo. Patch 2 does that.
>
> Thanks. LGTM.
TMT (To me, too)
Thanks,
Dscho
prev parent reply other threads:[~2021-03-01 22:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 20:12 [PATCH] t/perf: handle worktrees as test repos Jeff King
2021-02-16 20:16 ` Jeff King
2021-02-16 20:36 ` Derrick Stolee
2021-02-16 22:52 ` Junio C Hamano
2021-02-16 22:56 ` Jeff King
2021-02-16 21:13 ` Johannes Schindelin
2021-02-16 21:38 ` Jeff King
2021-02-26 7:09 ` [PATCH v2] t/perf worktree improvements Jeff King
2021-02-26 7:11 ` [PATCH v2 1/2] t/perf: handle worktrees as test repos Jeff King
2021-02-26 7:13 ` [PATCH v2 2/2] t/perf: avoid copying worktree files from test repo Jeff King
2021-02-26 15:43 ` [PATCH v2] t/perf worktree improvements Derrick Stolee
2021-03-01 22:03 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2103012302490.57@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).