From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: Re: [PATCH 1/2] config.mak.uname: remove redundant NO_LIBPCRE1_JIT flag
Date: Thu, 28 Jan 2021 16:44:09 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2101281641510.54@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20210124015833.2753-1-avarab@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
Hi Ævar,
On Sun, 24 Jan 2021, Ævar Arnfjörð Bjarmason wrote:
> Remove a flag added in my fb95e2e38d (grep: un-break building with
> PCRE >= 8.32 without --enable-jit, 2017-06-01). It's set just below
> USE_LIBPCRE=YesPlease, so it's been redundant since
> e6c531b808 (Makefile: make USE_LIBPCRE=YesPlease mean v2, not v1,
> 2018-03-11).
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> config.mak.uname | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 198ab1e58f..e22d4b6d67 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -664,7 +664,6 @@ else
> NO_GETTEXT =
> USE_GETTEXT_SCHEME = fallthrough
> USE_LIBPCRE= YesPlease
> - NO_LIBPCRE1_JIT = UnfortunatelyYes
FWIW this is almost precisely what we carry in Git for Windows for a while
(to battle-test it), as
https://github.com/git-for-windows/git/commit/735a58a38d43659cb985d717ec7eda1f26e121e5
The only thing that commit does in addition is to insert the forgotten
space in the line above, between `USE_LIBPCRE` and `=`.
Thanks,
Dscho
> NO_CURL =
> USE_NED_ALLOCATOR = YesPlease
> else
> --
> 2.29.2.222.g5d2a92d10f8
>
>
prev parent reply other threads:[~2021-01-28 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 1:58 [PATCH 1/2] config.mak.uname: remove redundant NO_LIBPCRE1_JIT flag Ævar Arnfjörð Bjarmason
2021-01-24 1:58 ` [PATCH 2/2] Remove support for v1 of the PCRE library Ævar Arnfjörð Bjarmason
2021-01-24 3:21 ` brian m. carlson
2021-01-24 5:14 ` Junio C Hamano
2021-01-28 15:44 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2101281641510.54@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).