From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Miriam Rubio <mirucam@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Finish converting git bisect to C part 3
Date: Mon, 18 Jan 2021 17:15:16 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2101181714370.52@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20201221162743.96056-1-mirucam@gmail.com>
Hi Miriam,
On Mon, 21 Dec 2020, Miriam Rubio wrote:
> These patches correspond to a third part of patch series
> of Outreachy project "Finish converting `git bisect` from shell to C"
> started by Pranit Bauva and Tanushree Tumane
> (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
> continued by me.
>
> This third part is formed by reimplementations of some `git bisect`
> subcommands and removal of some temporary subcommands.
>
> These patch series emails were generated from:
> https://gitlab.com/mirucam/git/commits/git-bisect-work-part3.
Nice, thank you very much!
I offered a couple suggestions how I think this patch series could be
improved even further.
Looking forward to the next iteration,
Dscho
>
> General changes
> ---------------
> * Rebase on master branch: 6d3ef5b467 (Git 2.30-rc1, 2020-12-18).
> * Change argv_array structs to strvec.
>
> Specific changes
> ----------------
>
> [1/7] bisect--helper: reimplement `bisect_log` shell function in C
> * Add `|| exit` to bisect_log call in shell script.
> ---
>
> [2/7] bisect--helper: reimplement `bisect_replay` shell function in C
> * Add `|| exit` to bisect_replay call in shell script.
> ---
>
> [6/7] bisect--helper: reimplement `bisect_skip` shell function in C
> * Add `|| exit` to bisect_skip call in shell script.
> ---
>
> Pranit Bauva (7):
> bisect--helper: reimplement `bisect_log` shell function in C
> bisect--helper: reimplement `bisect_replay` shell function in C
> bisect--helper: retire `--bisect-write` subcommand
> bisect--helper: use `res` instead of return in BISECT_RESET case
> option
> bisect--helper: retire `--bisect-auto-next` subcommand
> bisect--helper: reimplement `bisect_skip` shell function in C
> bisect--helper: retire `--check-and-set-terms` subcommand
>
> builtin/bisect--helper.c | 223 +++++++++++++++++++++++++++++++++------
> git-bisect.sh | 58 +---------
> 2 files changed, 195 insertions(+), 86 deletions(-)
>
> --
> 2.29.2
>
>
next prev parent reply other threads:[~2021-01-18 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 16:27 [PATCH v2 0/7] Finish converting git bisect to C part 3 Miriam Rubio
2020-12-21 16:27 ` [PATCH v2 1/7] bisect--helper: reimplement `bisect_log` shell function in C Miriam Rubio
2021-01-18 15:02 ` Johannes Schindelin
2020-12-21 16:27 ` [PATCH v2 2/7] bisect--helper: reimplement `bisect_replay` " Miriam Rubio
2020-12-22 0:15 ` Rafael Silva
2020-12-23 0:23 ` Rafael Silva
2020-12-23 1:36 ` Junio C Hamano
2020-12-23 10:03 ` Rafael Silva
2020-12-23 20:09 ` Junio C Hamano
2021-01-18 15:59 ` Johannes Schindelin
2020-12-21 16:27 ` [PATCH v2 3/7] bisect--helper: retire `--bisect-write` subcommand Miriam Rubio
2020-12-21 16:27 ` [PATCH v2 4/7] bisect--helper: use `res` instead of return in BISECT_RESET case option Miriam Rubio
2020-12-21 16:27 ` [PATCH v2 5/7] bisect--helper: retire `--bisect-auto-next` subcommand Miriam Rubio
2020-12-21 16:27 ` [PATCH v2 6/7] bisect--helper: reimplement `bisect_skip` shell function in C Miriam Rubio
2021-01-18 16:14 ` Johannes Schindelin
2020-12-21 16:27 ` [PATCH v2 7/7] bisect--helper: retire `--check-and-set-terms` subcommand Miriam Rubio
2021-01-18 16:15 ` Johannes Schindelin [this message]
2021-01-18 23:53 ` [PATCH v2 0/7] Finish converting git bisect to C part 3 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2101181714370.52@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mirucam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).