* Patchwork instance "Submitter" attribution and GitGitGadget
@ 2020-01-18 18:51 Philippe Blain
2020-01-20 12:16 ` Johannes Schindelin
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Blain @ 2020-01-18 18:51 UTC (permalink / raw)
To: jrnieder; +Cc: git, johannes.schindelin
Hi Jonathan,
I’ve noticed that all (I think) patch series sent to the list using Gitgitgadget are attributed to Dscho (Submitter is "Johannes Schindelin via GitGitGadget") on the patchwork instance [1]. I don’t know if you are aware of that or if there’s a way to fix it in patchwork…
Cheers,
Philippe.
[1] https://patchwork.kernel.org/project/git/list/?submitter=182351
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchwork instance "Submitter" attribution and GitGitGadget
2020-01-18 18:51 Patchwork instance "Submitter" attribution and GitGitGadget Philippe Blain
@ 2020-01-20 12:16 ` Johannes Schindelin
2020-01-21 17:53 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2020-01-20 12:16 UTC (permalink / raw)
To: Philippe Blain; +Cc: jrnieder, git
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
Hi Phillippe,
On Sat, 18 Jan 2020, Philippe Blain wrote:
> I’ve noticed that all (I think) patch series sent to the list using
> Gitgitgadget are attributed to Dscho (Submitter is "Johannes Schindelin
> via GitGitGadget") on the patchwork instance [1]. I don’t know if you
> are aware of that or if there’s a way to fix it in patchwork…
Right now, it shows "Lucius Hu via GitGitGadget". Clearly, patchwork uses
only the email address as identifier, being unprepared to accept that the
same email address might be used by multiple contributors.
Ciao,
Dscho
>
> Cheers,
> Philippe.
>
> [1] https://patchwork.kernel.org/project/git/list/?submitter=182351
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchwork instance "Submitter" attribution and GitGitGadget
2020-01-20 12:16 ` Johannes Schindelin
@ 2020-01-21 17:53 ` Junio C Hamano
2021-01-07 14:35 ` Johannes Schindelin
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2020-01-21 17:53 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Philippe Blain, jrnieder, git
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Sat, 18 Jan 2020, Philippe Blain wrote:
>
>> I’ve noticed that all (I think) patch series sent to the list using
>> Gitgitgadget are attributed to Dscho (Submitter is "Johannes Schindelin
>> via GitGitGadget") on the patchwork instance [1]. I don’t know if you
>> are aware of that or if there’s a way to fix it in patchwork…
>
> Right now, it shows "Lucius Hu via GitGitGadget". Clearly, patchwork uses
> only the email address as identifier, being unprepared to accept that the
> same email address might be used by multiple contributors.
Would it help to use the "Sender:" header? IIUC right now GGG
records its name on "From:" with its e-mail and a human-readable
name derived from the author of the ptach, but if it can record the
true author on "From:" and leave GGG's name on the "Sender:", would
patchwork use the "From:" side of the identity instead?
If that works, it would have an additional benefit of not having to
add the in-body "From:" to override the mail-header "From:", to avoid
attributing the authorship to GGG.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchwork instance "Submitter" attribution and GitGitGadget
2020-01-21 17:53 ` Junio C Hamano
@ 2021-01-07 14:35 ` Johannes Schindelin
2021-01-07 22:37 ` Konstantin Ryabitsev
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2021-01-07 14:35 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Philippe Blain, jrnieder, git
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
Hi Junio,
On Tue, 21 Jan 2020, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Sat, 18 Jan 2020, Philippe Blain wrote:
> >
> >> I’ve noticed that all (I think) patch series sent to the list using
> >> Gitgitgadget are attributed to Dscho (Submitter is "Johannes Schindelin
> >> via GitGitGadget") on the patchwork instance [1]. I don’t know if you
> >> are aware of that or if there’s a way to fix it in patchwork…
> >
> > Right now, it shows "Lucius Hu via GitGitGadget". Clearly, patchwork uses
> > only the email address as identifier, being unprepared to accept that the
> > same email address might be used by multiple contributors.
>
> Would it help to use the "Sender:" header? IIUC right now GGG
> records its name on "From:" with its e-mail and a human-readable
> name derived from the author of the ptach, but if it can record the
> true author on "From:" and leave GGG's name on the "Sender:", would
> patchwork use the "From:" side of the identity instead?
To tie up that loose end: GMail seemed to insist in my tests on replacing
the `From:` header, therefore we cannot implement this `Sender:` idea, not
using GMail to deliver the GitGitGadget patch series at least.
Ciao,
Dscho
> If that works, it would have an additional benefit of not having to
> add the in-body "From:" to override the mail-header "From:", to avoid
> attributing the authorship to GGG.
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchwork instance "Submitter" attribution and GitGitGadget
2021-01-07 14:35 ` Johannes Schindelin
@ 2021-01-07 22:37 ` Konstantin Ryabitsev
2021-01-08 15:07 ` Johannes Schindelin
0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2021-01-07 22:37 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Junio C Hamano, Philippe Blain, jrnieder, git
On Thu, Jan 07, 2021 at 03:35:54PM +0100, Johannes Schindelin wrote:
> > Would it help to use the "Sender:" header? IIUC right now GGG
> > records its name on "From:" with its e-mail and a human-readable
> > name derived from the author of the ptach, but if it can record the
> > true author on "From:" and leave GGG's name on the "Sender:", would
> > patchwork use the "From:" side of the identity instead?
>
> To tie up that loose end: GMail seemed to insist in my tests on replacing
> the `From:` header, therefore we cannot implement this `Sender:` idea, not
> using GMail to deliver the GitGitGadget patch series at least.
Can you possibly set X-Original-From: in the header? Patchwork almost does the
right thing with it, though right now it expects that the From: will be set to
the list's email address (which is only correct for google groups).
We have a workaround for the current situation on patchwork.kernel.org [1],
but it requires parsing the body of the message instead of just relying on the
headers.
> > If that works, it would have an additional benefit of not having to
> > add the in-body "From:" to override the mail-header "From:", to avoid
> > attributing the authorship to GGG.
Using the in-body From: is both good and proper for such service. Trying to
put the author's email into the actual From will run afoul of SPF.
-K
[1] https://git.kernel.org/pub/scm/infra/patchwork/procmail.git/tree/git.rc
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patchwork instance "Submitter" attribution and GitGitGadget
2021-01-07 22:37 ` Konstantin Ryabitsev
@ 2021-01-08 15:07 ` Johannes Schindelin
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Schindelin @ 2021-01-08 15:07 UTC (permalink / raw)
To: Konstantin Ryabitsev; +Cc: Junio C Hamano, Philippe Blain, jrnieder, git
Hi Konst,
On Thu, 7 Jan 2021, Konstantin Ryabitsev wrote:
> On Thu, Jan 07, 2021 at 03:35:54PM +0100, Johannes Schindelin wrote:
> > > Would it help to use the "Sender:" header? IIUC right now GGG
> > > records its name on "From:" with its e-mail and a human-readable
> > > name derived from the author of the ptach, but if it can record the
> > > true author on "From:" and leave GGG's name on the "Sender:", would
> > > patchwork use the "From:" side of the identity instead?
> >
> > To tie up that loose end: GMail seemed to insist in my tests on replacing
> > the `From:` header, therefore we cannot implement this `Sender:` idea, not
> > using GMail to deliver the GitGitGadget patch series at least.
>
> Can you possibly set X-Original-From: in the header?
Potentially. But unfortunately, I am too short on time to perform such
experiments right now. And it is always subject to the question what GMail
does with this header in the future. `Sender:` used to work IIRC, but now
it doesn't.
> Patchwork almost does the right thing with it, though right now it
> expects that the From: will be set to the list's email address (which is
> only correct for google groups).
>
> We have a workaround for the current situation on patchwork.kernel.org [1],
> but it requires parsing the body of the message instead of just relying on the
> headers.
>
> > > If that works, it would have an additional benefit of not having to
> > > add the in-body "From:" to override the mail-header "From:", to avoid
> > > attributing the authorship to GGG.
>
> Using the in-body From: is both good and proper for such service. Trying to
> put the author's email into the actual From will run afoul of SPF.
Indeed.
Therefore, I would prefer to keep doing that in GitGitGadget: send from
its regular email address, and add the contributor's info in-body.
Ciao,
Johannes
>
> -K
>
> [1] https://git.kernel.org/pub/scm/infra/patchwork/procmail.git/tree/git.rc
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-08 15:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 18:51 Patchwork instance "Submitter" attribution and GitGitGadget Philippe Blain
2020-01-20 12:16 ` Johannes Schindelin
2020-01-21 17:53 ` Junio C Hamano
2021-01-07 14:35 ` Johannes Schindelin
2021-01-07 22:37 ` Konstantin Ryabitsev
2021-01-08 15:07 ` Johannes Schindelin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).