git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
* [PATCH] t3040: remove stale note
@ 2020-11-18 19:25 Johannes Schindelin via GitGitGadget
  2020-11-18 20:50 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin via GitGitGadget @ 2020-11-18 19:25 UTC (permalink / raw)
  To: git; +Cc: Alex Riesen, Johannes Schindelin, Johannes Schindelin

From: Johannes Schindelin <johannes.schindelin@gmx.de>

This comment was most likely a "note to self" during the development of
1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is
neither needed nor comprehensible at this point. Let's remove it.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    t3040: remove stale note
    
    And yet another thing I noticed while working on 
    https://github.com/gitgitgadget/git/pull/762.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-793%2Fdscho%2Ft3040-and-default-branch-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-793/dscho/t3040-and-default-branch-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/793

 t/t3040-subprojects-basic.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/t/t3040-subprojects-basic.sh b/t/t3040-subprojects-basic.sh
index b81eb5fd6f..6abdcbbc94 100755
--- a/t/t3040-subprojects-basic.sh
+++ b/t/t3040-subprojects-basic.sh
@@ -79,7 +79,4 @@ test_expect_success 'checkout in superproject' '
 	git diff-index --exit-code --raw --cached save -- sub1
 '
 
-# just interesting what happened...
-# git diff --name-status -M save master
-
 test_done

base-commit: e31aba42fb12bdeb0f850829e008e1e3f43af500
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] t3040: remove stale note
  2020-11-18 19:25 [PATCH] t3040: remove stale note Johannes Schindelin via GitGitGadget
@ 2020-11-18 20:50 ` Junio C Hamano
  2020-11-19 11:23   ` Johannes Schindelin
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2020-11-18 20:50 UTC (permalink / raw)
  To: Johannes Schindelin via GitGitGadget
  Cc: git, Alex Riesen, Johannes Schindelin

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> This comment was most likely a "note to self" during the development of
> 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is
> neither needed nor comprehensible at this point. Let's remove it.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>     t3040: remove stale note
>     
>     And yet another thing I noticed while working on 
>     https://github.com/gitgitgadget/git/pull/762.

It seems that all test updates from you today are some form of
refinement to the 27-patch series we have in 'seen'.  I'll resolve
conflicts in favor of these new ones as they look strict improvement
(modulo @{2} thing I mentioned separately) in the meantime, but
let's not forget to remove them from a reroll of the large series.

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] t3040: remove stale note
  2020-11-18 20:50 ` Junio C Hamano
@ 2020-11-19 11:23   ` Johannes Schindelin
  0 siblings, 0 replies; 3+ messages in thread
From: Johannes Schindelin @ 2020-11-19 11:23 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Johannes Schindelin via GitGitGadget, git, Alex Riesen

Hi Junio,

On Wed, 18 Nov 2020, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > This comment was most likely a "note to self" during the development of
> > 1c3e5c4ebc3 (Tests for core subproject support, 2007-04-19) and is
> > neither needed nor comprehensible at this point. Let's remove it.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     t3040: remove stale note
> >
> >     And yet another thing I noticed while working on
> >     https://github.com/gitgitgadget/git/pull/762.
>
> It seems that all test updates from you today are some form of
> refinement to the 27-patch series we have in 'seen'.  I'll resolve
> conflicts in favor of these new ones as they look strict improvement
> (modulo @{2} thing I mentioned separately) in the meantime, but
> let's not forget to remove them from a reroll of the large series.

I didn't ;-) See
https://lore.kernel.org/git/pull.762.v3.git.1605743086.gitgitgadget@gmail.com/

Ciao,
Dscho

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-19 11:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 19:25 [PATCH] t3040: remove stale note Johannes Schindelin via GitGitGadget
2020-11-18 20:50 ` Junio C Hamano
2020-11-19 11:23   ` Johannes Schindelin

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git