From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <email@example.com>
Cc: "SZEDER Gábor" <firstname.lastname@example.org>,
"brian m. carlson" <email@example.com>,
"Junio C Hamano" <firstname.lastname@example.org>
Subject: Re: [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256
Date: Thu, 19 Nov 2020 12:19:10 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.email@example.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
On Wed, 18 Nov 2020, Jeff King wrote:
> On Wed, Nov 18, 2020 at 07:30:22PM +0100, SZEDER Gábor wrote:
> > > I wonder whether there is a way to change the `JGIT` prereq in a way
> > > that automagically will recognize a (future) SHA256-enabled JGit?
> > > Something like
> > >
> > > test_lazy_prereq JGIT '
> > > jgit --version &&
> > > test_have_prereq !SHA1 ||
> > > test "$(git rev-list -n 1 HEAD)" = "$(jgit rev-list -n 1 HEAD)"
> > > '
> > >
> > > What do you think?
> > I'm not sure. It is surely a substantial effort to fully support
> > SHA256, and I suppose there will be JGit versions with only partial
> > support. I'm worried that there will be versions that can already
> > read SHA256 objects, but can't read/write SHA256 pack bitmaps, or
> > can't transfer/negotiate SHA256 objects yet (for t5512), so even
> > though they could fulfill such a prereq test above, the test would
> > still fail.
> Yeah, it's likely we'll need to just match the output of "jgit
> --version". Since their support is hypothetical at this point, I think
> it makes sense to go with your original patch. It does mean we'll later
> have to remove the SHA1 prereq from those tests, but that's OK. It's not
> very many tests, and your commit message clearly explains what is going
It's not just removing the SHA-1 prereq, but testing for a new-enough
This most likely entails adding a new test helper to `t/helper/` that
allows using `versioncmp()` via the command-line, with some clever way to
indicate the different outcomes, and then using that in a new prereq.
You know, if it was me, I would opt for the simpler (and future-proof)
solution I presented above. But hey, if that complex solution using
`versioncmp()` floats your boat, who am I to stop you.
next prev parent reply other threads:[~2020-11-19 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 21:53 [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256 SZEDER Gábor
2020-11-13 21:56 ` Taylor Blau
2020-11-13 23:43 ` brian m. carlson
2020-11-15 21:13 ` SZEDER Gábor
2020-11-15 22:08 ` Johannes Schindelin
2020-11-18 18:30 ` SZEDER Gábor
2020-11-18 18:45 ` Jeff King
2020-11-19 11:19 ` Johannes Schindelin [this message]
2020-11-19 15:44 ` Jeff King
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).