From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Daniel Gurney <dgurney99@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH v2] compat/bswap.h: simplify MSVC endianness detection
Date: Tue, 10 Nov 2020 16:47:17 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2011101643460.18437@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <f41271c0-973d-ee3f-9535-d7fbc5b073cf@gmail.com>
Hi Daniel,
On Tue, 10 Nov 2020, Daniel Gurney wrote:
> On 10/11/2020 16:04, Johannes Schindelin wrote:
> > Point in reference:
> > you can build Linux applications in Visual Studio like _right now_ [*1*].
> >
> > Ciao,
> > Dscho
> >
> > Footnote *1*: It currently uses GCC, but who says it always will?
> > https://docs.microsoft.com/en-us/cpp/linux/cmake-linux-project
>
> When it comes to building C++ code MSVC uses Microsoft's C++ Standard Library,
> and one of its stated non-goals[1] is being ported to other systems. I assume
> the same applies for their C library. Therefore to me a scenario where a
> future version of MSVC would build non-Windows code, let alone for a
> big-endian architecture, seems extremely unlikely.
Well, we know for a fact that at least XBox is a big-endian system and
ther are rumors out there that Visual Studio _might_ be used to build
software for that system.
Of course, I am not suggesting that we should build Git for XBox. But it
seems dangerous to me to make too many assumptions.
> That said, I understand your overall point of view perfectly, and I'm fine
> with either one of my patches being applied since the end result today is the
> same.
As a maintainer, I am less concerned about the "result today" than I am
about keeping things easy and effortless to maintain. One of your patches
accomplishes that. The other one made it into `next`:
https://github.com/git/git/commit/91a67b86f77
Ciao,
Dscho
next prev parent reply other threads:[~2020-11-10 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 23:47 [PATCH] compat/bswap.h: Simplify MSVC endianness detection Daniel Gurney
2020-11-08 0:12 ` brian m. carlson
2020-11-08 9:57 ` [PATCH v2] compat/bswap.h: simplify " Daniel Gurney
2020-11-10 0:31 ` Jeff King
2020-11-10 2:36 ` brian m. carlson
2020-11-10 6:00 ` Junio C Hamano
2020-11-10 14:04 ` Johannes Schindelin
2020-11-10 15:35 ` Daniel Gurney
2020-11-10 15:47 ` Johannes Schindelin [this message]
2020-11-10 17:20 ` Junio C Hamano
2020-11-10 17:30 ` Junio C Hamano
2020-11-10 22:37 ` Johannes Schindelin
2020-11-10 14:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2011101643460.18437@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=dgurney99@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).