From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
phillip.wood@dunelm.org.uk,
Sangeeta via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Sangeeta <sangunb09@gmail.com>
Subject: Re: [PATCH][OUTREACHY] bisect: allow `git bisect` to run from subdirectory
Date: Thu, 22 Oct 2020 10:52:45 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2010221047550.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqr1pr73ve.fsf@gitster.c.googlers.com>
Hi Junio,
On Wed, 21 Oct 2020, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> > I'm not sure that that's the case: Junio pointed out a while[1] ago that
> > we'd have to answer the question of "what happens if I'm in a
> > subdirectory that goes away during some point of the bisection?". I
> > think that you could probably find an answer to that question, but the
> > fact that there isn't an obvious one seems to indicate that we're going
> > down the wrong path.
> >
> > I agree that it would be nice to run bisect from any directory, but it
> > may not be as easy as I'd hope.
>
> True.
>
> I would not mind all that much a single "git checkout ancient" that
> makes the $cwd go away and confuse the user. But a bisect session
> would jump around versions randomly (eh, logarithmically?) and you'd
> end up switching out of a version in a non-existing $cwd to another
> version that has the directory (created internally by mkdir(2)), and
> I'm fairly certain that your phantom $cwd that is not connected to
> any other filesystem entity and the directory that should be at the
> same path in the newly checked-out version are different filesystem
> entities. I'd rather not have to think about the interaction
> between git and the system after that point.
By that token, we should also prevent `git rebase` from running in a
subdirectory, but we don't.
Besides, this only becomes an issue when the directory becomes _empty_
(including untracked files) because we don't remove it otherwise.
I am actually more worried about bisecting between revisions that replace
the current subdirectory by a symlink or something.
But again, this is pretty much precisely the kind of scenario that we
_already_ allow running into with `git rebase`. So I see little point
refusing `git bisect` users to run in a subdirectory.
I know that _I_ often grumble after `git bisect start` fails, then try to
pull out the last remains of my patience and insert `-C ..` or `-C ../..`
between `git` and `bisect` and _still_ get what I want, all while shaking
my imaginary fist at `git bisect` for forcing me to type those extra
keystrokes.
Ciao,
Dscho
next prev parent reply other threads:[~2020-10-22 8:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 9:09 [PATCH] bisect: allow `git bisect` to run from subdirectory Sangeeta via GitGitGadget
2020-10-21 13:41 ` [PATCH][OUTREACHY] " Phillip Wood
2020-10-21 16:20 ` Taylor Blau
2020-10-21 19:53 ` Junio C Hamano
2020-10-22 8:52 ` Johannes Schindelin [this message]
2020-10-22 9:46 ` Phillip Wood
2020-10-22 16:52 ` Junio C Hamano
2020-10-23 10:59 ` Sangeeta NB
2020-10-23 15:43 ` Junio C Hamano
2020-10-23 15:18 ` Phillip Wood
2020-10-22 8:47 ` Johannes Schindelin
2020-10-22 9:52 ` Phillip Wood
2020-10-22 17:04 ` Junio C Hamano
2020-10-23 8:37 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2010221047550.56@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sangunb09@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).