From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Nikita Leonov via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Nikita Leonov <nykyta.leonov@gmail.com>
Subject: Re: [PATCH v2 1/3] credential.c: fix credential reading with regards to CR/LF
Date: Fri, 2 Oct 2020 14:27:23 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2010021427080.50@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20201002120126.GA2255314@coredump.intra.peff.net>
Hi Peff,
On Fri, 2 Oct 2020, Jeff King wrote:
> On Fri, Oct 02, 2020 at 01:37:23PM +0200, Johannes Schindelin wrote:
>
> > But I would highly doubt that the empty lines were the biggest problem:
> > Sure, we would fail to recognize an empty line with CR/LF line endings
> > when reading with `strbuf_getline_lf()`, but we would totally
> > misunderstand the entire rest of the lines, too. For example, we would
> > mistake `quit\r` for an unknown command, and hence simply ignore it.
> >
> > I do agree, however, that your confusion validly points out a flaw in the
> > commit message: the "empty line" comment is a red herring.
> >
> > Therefore, I spent some time pouring over the commit message. This is my
> > current version:
> > [...]
> > What do you think?
>
> I think we are on the same page, and this revision does a good job of
> fixing my complaint about the commit message. Thanks. One minor typo:
>
> > While we do this for the credential helper protocol, we do _not_ do
> > adjust `git credential-cache--daemon` (which won't work on Windows,
>
> s/do$//
Thanks, fixed!
Ciao,
Dscho
next prev parent reply other threads:[~2020-10-02 12:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:49 [PATCH] credential.c: fix credential reading with regards to CR/LF Johannes Schindelin via GitGitGadget
2020-02-14 17:55 ` Junio C Hamano
2020-02-14 18:32 ` Jeff King
2020-09-28 11:40 ` [PATCH v2 0/3] Prepare git credential to read input with DOS line endings Johannes Schindelin via GitGitGadget
2020-09-28 11:40 ` [PATCH v2 1/3] credential.c: fix credential reading with regards to CR/LF Nikita Leonov via GitGitGadget
2020-09-29 0:42 ` Jeff King
2020-10-02 11:37 ` Johannes Schindelin
2020-10-02 12:01 ` Jeff King
2020-10-02 12:27 ` Johannes Schindelin [this message]
2020-10-02 16:32 ` Junio C Hamano
2020-10-03 13:28 ` Johannes Schindelin
2020-09-28 11:40 ` [PATCH v2 2/3] credentials: make line reading Windows compatible Nikita Leonov via GitGitGadget
2020-09-28 20:58 ` Junio C Hamano
2020-09-29 0:35 ` Jeff King
2020-09-30 22:33 ` Junio C Hamano
2020-10-02 7:53 ` Johannes Schindelin
2020-09-28 23:26 ` Carlo Arenas
2020-09-28 23:41 ` Junio C Hamano
2020-09-29 0:30 ` Jeff King
2020-09-29 0:41 ` Junio C Hamano
2020-09-29 0:44 ` Jeff King
2020-09-29 0:54 ` Junio C Hamano
2020-09-29 3:00 ` Jeff King
2020-09-30 22:25 ` Junio C Hamano
2020-09-30 22:39 ` Jeff King
2020-09-30 22:56 ` Junio C Hamano
2020-10-01 13:54 ` Jeff King
2020-10-01 15:42 ` Junio C Hamano
2020-10-02 8:07 ` Johannes Schindelin
2020-09-28 11:40 ` [PATCH v2 3/3] docs: make notes regarding credential line reading Nikita Leonov via GitGitGadget
2020-09-28 20:31 ` [PATCH v2 0/3] Prepare git credential to read input with DOS line endings Junio C Hamano
2020-10-03 13:29 ` [PATCH v3] credential: treat CR/LF as line endings in the credential protocol Johannes Schindelin via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2010021427080.50@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=nykyta.leonov@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).