From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git <git@vger.kernel.org>,
Christian Couder <chriscool@tuxfamily.org>,
Miriam Rubio <mirucam@gmail.com>
Subject: Re: [PATCH] bisect: don't use invalid oid as rev when starting
Date: Fri, 25 Sep 2020 09:13:44 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2009250910200.5061@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqwo0jm356.fsf@gitster.c.googlers.com>
Hi Junio,
On Thu, 24 Sep 2020, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >
> >>> Hopefully the V2 I just sent will be better anyway.
> >>
> >> FWIW I was working off of Miriam's `git-bisect-work-part2-v8` branch at
> >> https://gitlab.com/mirucam/git.git.
> >>
> >> I'm happy with Christian's v2 (with or without the indentation fixes I
> >> suggested).
> >
> > Thanks, both of you. The updated one does look good.
>
> Oops, do you mean s/path restriction/pathspec/ fix? v2 looks OK nesting-wise
> and I think your indentex-fix suggestion was for the previous one.
I was referring to the indentation of the -/+ lines in the commit message.
Your current `SQUASH???` does not include the line-shortening, but that's
okay. I slightly prefer the version where single conditional statements
lose the curly brackets, but that's just nit-picking.
A slightly bigger question is whether `git_oid_committish()` would be okay
enough, or whether we do need `get_oidf(&oid, "%s^{commit}", arg)` (as
your `SQUASH???` does).
I'm not quite sure: aren't those two calls idempotent, with the latter
going through some unnecessary string processing dances?
Ciao,
Dscho
next prev parent reply other threads:[~2020-09-25 11:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 17:09 [PATCH] bisect: don't use invalid oid as rev when starting Christian Couder
2020-09-23 17:27 ` Junio C Hamano
2020-09-23 20:37 ` Johannes Schindelin
2020-09-23 21:05 ` Johannes Schindelin
2020-09-23 21:39 ` Junio C Hamano
2020-09-24 6:10 ` Christian Couder
2020-09-24 6:48 ` Junio C Hamano
2020-09-24 7:51 ` Johannes Schindelin
2020-09-24 16:39 ` Junio C Hamano
2020-09-24 18:38 ` Junio C Hamano
2020-09-25 7:13 ` Johannes Schindelin [this message]
2020-09-25 7:14 ` Johannes Schindelin
2020-09-25 16:54 ` Junio C Hamano
2020-09-24 6:03 ` [PATCH v2] " Christian Couder
2020-09-24 7:49 ` Johannes Schindelin
2020-09-24 11:08 ` Christian Couder
2020-09-24 16:44 ` Junio C Hamano
2020-09-24 18:55 ` Junio C Hamano
2020-09-24 19:25 ` Junio C Hamano
2020-09-24 19:56 ` Junio C Hamano
2020-09-24 20:53 ` Junio C Hamano
2020-09-25 13:09 ` Christian Couder
2020-09-25 13:01 ` [PATCH v3] " Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2009250910200.5061@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mirucam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).