* [PATCH] vcbuild: fix batch file name in README
@ 2020-09-02 20:18 Orgad Shaneh via GitGitGadget
2020-09-03 0:02 ` Jonathan Nieder
2020-09-03 1:50 ` Johannes Schindelin
0 siblings, 2 replies; 4+ messages in thread
From: Orgad Shaneh via GitGitGadget @ 2020-09-02 20:18 UTC (permalink / raw)
To: git; +Cc: Orgad Shaneh, Orgad Shaneh
From: Orgad Shaneh <orgads@gmail.com>
Signed-off-by: Orgad Shaneh <orgads@gmail.com>
---
vcbuild: Fix batch file name in README
Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/721
compat/vcbuild/README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/compat/vcbuild/README b/compat/vcbuild/README
index 42292e7c09..51fb083dbb 100644
--- a/compat/vcbuild/README
+++ b/compat/vcbuild/README
@@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.
Use ONE of the following forms which should match how you want to
compile git.exe.
- $ ./compat/vcbuild/vcpkg_copy_packages.bat debug
- $ ./compat/vcbuild/vcpkg_copy_packages.bat release
+ $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug
+ $ ./compat/vcbuild/vcpkg_copy_dlls.bat release
3. Build git using MSVC from an SDK bash window using one of the
following commands:
base-commit: e19713638985533ce461db072b49112da5bd2042
--
gitgitgadget
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] vcbuild: fix batch file name in README
2020-09-02 20:18 [PATCH] vcbuild: fix batch file name in README Orgad Shaneh via GitGitGadget
@ 2020-09-03 0:02 ` Jonathan Nieder
2020-09-03 1:55 ` Johannes Schindelin
2020-09-03 1:50 ` Johannes Schindelin
1 sibling, 1 reply; 4+ messages in thread
From: Jonathan Nieder @ 2020-09-03 0:02 UTC (permalink / raw)
To: Orgad Shaneh via GitGitGadget; +Cc: git, Orgad Shaneh, Jeff Hostetler
(cc-ing Jeff Hostetler, vcbuild expert)
Orgad Shaneh wrote:
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/721
>
> compat/vcbuild/README | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Makes sense. This discrepancy is already present in the initial
contribution dce7d295514 (msvc: support building Git using MS Visual
C++, 2019-06-25), so it's probably from documentation going out of
date between review rounds.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> diff --git a/compat/vcbuild/README b/compat/vcbuild/README
> index 42292e7c09..51fb083dbb 100644
> --- a/compat/vcbuild/README
> +++ b/compat/vcbuild/README
> @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.
> Use ONE of the following forms which should match how you want to
> compile git.exe.
>
> - $ ./compat/vcbuild/vcpkg_copy_packages.bat debug
> - $ ./compat/vcbuild/vcpkg_copy_packages.bat release
> + $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug
> + $ ./compat/vcbuild/vcpkg_copy_dlls.bat release
>
> 3. Build git using MSVC from an SDK bash window using one of the
> following commands:
>
> base-commit: e19713638985533ce461db072b49112da5bd2042
> --
> gitgitgadget
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vcbuild: fix batch file name in README
2020-09-03 0:02 ` Jonathan Nieder
@ 2020-09-03 1:55 ` Johannes Schindelin
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Schindelin @ 2020-09-03 1:55 UTC (permalink / raw)
To: Jonathan Nieder
Cc: Orgad Shaneh via GitGitGadget, git, Orgad Shaneh, Jeff Hostetler
Hi Jonathan,
On Wed, 2 Sep 2020, Jonathan Nieder wrote:
> (cc-ing Jeff Hostetler, vcbuild expert)
> Orgad Shaneh wrote:
>
> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> > ---
> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1
> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1
> > Pull-Request: https://github.com/gitgitgadget/git/pull/721
> >
> > compat/vcbuild/README | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Makes sense. This discrepancy is already present in the initial
> contribution dce7d295514 (msvc: support building Git using MS Visual
> C++, 2019-06-25), so it's probably from documentation going out of
> date between review rounds.
Not in _public_ review rounds, as even the first version I sent did not
have that `.bat` file anymore:
https://github.com/gitgitgadget/git/tree/pr-149/dscho/msvc-v1/compat/vcbuild
FWIW the old name was a hold-over from the time when we tried to use NuGet
packages (and I think this is the first time I mentioned this on this here
mailing list), which we were able to abandon in favor of using `vcpkg`.
Ciao,
Dscho
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> > diff --git a/compat/vcbuild/README b/compat/vcbuild/README
> > index 42292e7c09..51fb083dbb 100644
> > --- a/compat/vcbuild/README
> > +++ b/compat/vcbuild/README
> > @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.
> > Use ONE of the following forms which should match how you want to
> > compile git.exe.
> >
> > - $ ./compat/vcbuild/vcpkg_copy_packages.bat debug
> > - $ ./compat/vcbuild/vcpkg_copy_packages.bat release
> > + $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug
> > + $ ./compat/vcbuild/vcpkg_copy_dlls.bat release
> >
> > 3. Build git using MSVC from an SDK bash window using one of the
> > following commands:
> >
> > base-commit: e19713638985533ce461db072b49112da5bd2042
> > --
> > gitgitgadget
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vcbuild: fix batch file name in README
2020-09-02 20:18 [PATCH] vcbuild: fix batch file name in README Orgad Shaneh via GitGitGadget
2020-09-03 0:02 ` Jonathan Nieder
@ 2020-09-03 1:50 ` Johannes Schindelin
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Schindelin @ 2020-09-03 1:50 UTC (permalink / raw)
To: Orgad Shaneh via GitGitGadget; +Cc: git, Orgad Shaneh, Orgad Shaneh
Hi Orgad,
On Wed, 2 Sep 2020, Orgad Shaneh via GitGitGadget wrote:
> From: Orgad Shaneh <orgads@gmail.com>
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
> vcbuild: Fix batch file name in README
>
> Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/721
>
> compat/vcbuild/README | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/compat/vcbuild/README b/compat/vcbuild/README
> index 42292e7c09..51fb083dbb 100644
> --- a/compat/vcbuild/README
> +++ b/compat/vcbuild/README
> @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.
> Use ONE of the following forms which should match how you want to
> compile git.exe.
>
> - $ ./compat/vcbuild/vcpkg_copy_packages.bat debug
> - $ ./compat/vcbuild/vcpkg_copy_packages.bat release
> + $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug
> + $ ./compat/vcbuild/vcpkg_copy_dlls.bat release
Good catch! Somewhere in my refactoring spree, I must have overlooked this
reference.
ACK & Thanks,
Dscho
>
> 3. Build git using MSVC from an SDK bash window using one of the
> following commands:
>
> base-commit: e19713638985533ce461db072b49112da5bd2042
> --
> gitgitgadget
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-03 10:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 20:18 [PATCH] vcbuild: fix batch file name in README Orgad Shaneh via GitGitGadget
2020-09-03 0:02 ` Jonathan Nieder
2020-09-03 1:55 ` Johannes Schindelin
2020-09-03 1:50 ` Johannes Schindelin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).