From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Orgad Shaneh <orgads@gmail.com>,
Jeff Hostetler <git@jeffhostetler.com>
Subject: Re: [PATCH] vcbuild: fix batch file name in README
Date: Thu, 3 Sep 2020 03:55:20 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2009030353500.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20200903000236.GC4035286@google.com>
Hi Jonathan,
On Wed, 2 Sep 2020, Jonathan Nieder wrote:
> (cc-ing Jeff Hostetler, vcbuild expert)
> Orgad Shaneh wrote:
>
> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> > ---
> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-721%2Forgads%2Fvcbuild-readme-v1
> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-721/orgads/vcbuild-readme-v1
> > Pull-Request: https://github.com/gitgitgadget/git/pull/721
> >
> > compat/vcbuild/README | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Makes sense. This discrepancy is already present in the initial
> contribution dce7d295514 (msvc: support building Git using MS Visual
> C++, 2019-06-25), so it's probably from documentation going out of
> date between review rounds.
Not in _public_ review rounds, as even the first version I sent did not
have that `.bat` file anymore:
https://github.com/gitgitgadget/git/tree/pr-149/dscho/msvc-v1/compat/vcbuild
FWIW the old name was a hold-over from the time when we tried to use NuGet
packages (and I think this is the first time I mentioned this on this here
mailing list), which we were able to abandon in favor of using `vcpkg`.
Ciao,
Dscho
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> > diff --git a/compat/vcbuild/README b/compat/vcbuild/README
> > index 42292e7c09..51fb083dbb 100644
> > --- a/compat/vcbuild/README
> > +++ b/compat/vcbuild/README
> > @@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.
> > Use ONE of the following forms which should match how you want to
> > compile git.exe.
> >
> > - $ ./compat/vcbuild/vcpkg_copy_packages.bat debug
> > - $ ./compat/vcbuild/vcpkg_copy_packages.bat release
> > + $ ./compat/vcbuild/vcpkg_copy_dlls.bat debug
> > + $ ./compat/vcbuild/vcpkg_copy_dlls.bat release
> >
> > 3. Build git using MSVC from an SDK bash window using one of the
> > following commands:
> >
> > base-commit: e19713638985533ce461db072b49112da5bd2042
> > --
> > gitgitgadget
>
next prev parent reply other threads:[~2020-09-03 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 20:18 [PATCH] vcbuild: fix batch file name in README Orgad Shaneh via GitGitGadget
2020-09-03 0:02 ` Jonathan Nieder
2020-09-03 1:55 ` Johannes Schindelin [this message]
2020-09-03 1:50 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2009030353500.56@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jrnieder@gmail.com \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).