git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH] vcbuild: fix library name for expat with make MSVC=1
@ 2020-09-02 20:16 Orgad Shaneh via GitGitGadget
  2020-09-03  0:06 ` Jonathan Nieder
  2020-09-03  1:42 ` Johannes Schindelin
  0 siblings, 2 replies; 4+ messages in thread
From: Orgad Shaneh via GitGitGadget @ 2020-09-02 20:16 UTC (permalink / raw)
  To: git; +Cc: Orgad Shaneh, Orgad Shaneh

From: Orgad Shaneh <orgads@gmail.com>

Signed-off-by: Orgad Shaneh <orgads@gmail.com>
---
    vcbuild: fix library name for expat with make MSVC=1
    
    Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/722

 compat/vcbuild/scripts/clink.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
index 61ad084a7b..df167d1e1a 100755
--- a/compat/vcbuild/scripts/clink.pl
+++ b/compat/vcbuild/scripts/clink.pl
@@ -66,7 +66,7 @@
 		}
 		push(@args, $lib);
 	} elsif ("$arg" eq "-lexpat") {
-		push(@args, "expat.lib");
+		push(@args, "libexpat.lib");
 	} elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
 		$arg =~ s/^-L/-LIBPATH:/;
 		push(@lflags, $arg);

base-commit: e19713638985533ce461db072b49112da5bd2042
-- 
gitgitgadget

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1
  2020-09-02 20:16 [PATCH] vcbuild: fix library name for expat with make MSVC=1 Orgad Shaneh via GitGitGadget
@ 2020-09-03  0:06 ` Jonathan Nieder
  2020-09-03  2:07   ` Junio C Hamano
  2020-09-03  1:42 ` Johannes Schindelin
  1 sibling, 1 reply; 4+ messages in thread
From: Jonathan Nieder @ 2020-09-03  0:06 UTC (permalink / raw)
  To: Orgad Shaneh via GitGitGadget
  Cc: git, Orgad Shaneh, Jeff Hostetler, Johannes Schindelin

(cc-ing a couple of Windows experts)
Orgad Shaneh wrote:

> Subject: vcbuild: fix library name for expat with make MSVC=1

Do you have more details?  For example, what error message does the
build produce without this change?

> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/722
>
>  compat/vcbuild/scripts/clink.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm ignorant enough about the platform-specific details involved that
I'd like an Ack from one of the Windows folks.

Thanks,
Jonathan

> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
> index 61ad084a7b..df167d1e1a 100755
> --- a/compat/vcbuild/scripts/clink.pl
> +++ b/compat/vcbuild/scripts/clink.pl
> @@ -66,7 +66,7 @@
>  		}
>  		push(@args, $lib);
>  	} elsif ("$arg" eq "-lexpat") {
> -		push(@args, "expat.lib");
> +		push(@args, "libexpat.lib");
>  	} elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
>  		$arg =~ s/^-L/-LIBPATH:/;
>  		push(@lflags, $arg);
> 
> base-commit: e19713638985533ce461db072b49112da5bd2042
> -- 
> gitgitgadget

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1
  2020-09-02 20:16 [PATCH] vcbuild: fix library name for expat with make MSVC=1 Orgad Shaneh via GitGitGadget
  2020-09-03  0:06 ` Jonathan Nieder
@ 2020-09-03  1:42 ` Johannes Schindelin
  1 sibling, 0 replies; 4+ messages in thread
From: Johannes Schindelin @ 2020-09-03  1:42 UTC (permalink / raw)
  To: Orgad Shaneh via GitGitGadget; +Cc: git, Orgad Shaneh, Orgad Shaneh

Hi Orgad,

On Wed, 2 Sep 2020, Orgad Shaneh via GitGitGadget wrote:

> From: Orgad Shaneh <orgads@gmail.com>
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
>     vcbuild: fix library name for expat with make MSVC=1
>
>     Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]

As can be seen at
https://dev.azure.com/git/git/_build/results?buildId=2065&view=artifacts&type=publishedArtifacts,
this change is correct.

ACK.

Thank you,
Dscho

>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/722
>
>  compat/vcbuild/scripts/clink.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
> index 61ad084a7b..df167d1e1a 100755
> --- a/compat/vcbuild/scripts/clink.pl
> +++ b/compat/vcbuild/scripts/clink.pl
> @@ -66,7 +66,7 @@
>  		}
>  		push(@args, $lib);
>  	} elsif ("$arg" eq "-lexpat") {
> -		push(@args, "expat.lib");
> +		push(@args, "libexpat.lib");
>  	} elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
>  		$arg =~ s/^-L/-LIBPATH:/;
>  		push(@lflags, $arg);
>
> base-commit: e19713638985533ce461db072b49112da5bd2042
> --
> gitgitgadget
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1
  2020-09-03  0:06 ` Jonathan Nieder
@ 2020-09-03  2:07   ` Junio C Hamano
  0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2020-09-03  2:07 UTC (permalink / raw)
  To: Jonathan Nieder
  Cc: Orgad Shaneh via GitGitGadget, git, Orgad Shaneh, Jeff Hostetler,
	Johannes Schindelin

Jonathan Nieder <jrnieder@gmail.com> writes:

> (cc-ing a couple of Windows experts)
> Orgad Shaneh wrote:
>
>> Subject: vcbuild: fix library name for expat with make MSVC=1
>
> Do you have more details?  For example, what error message does the
> build produce without this change?

Presumably you'd get an error at link time, saying either 'no such
library: expat.lib', or 'symbol X not found' for symbols that were
supposed to come from libexpat.lib.

I do not think we want to see exact error message.  If an empty body
of the log message bothers us, I probably would say that it is
sufficient to write something like

    The name of the expat library is libexpat.lib, not expat.lib;
    otherwise we'd get linkage errors.

> I'm ignorant enough about the platform-specific details involved that
> I'd like an Ack from one of the Windows folks.

I saw Dscho looked at both pull requests and commented on them, but
haven't seen him (or anybody else) acking or nacking the version
that was submitted.  It would be nice to see an Ack from Windows'
side.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-03 10:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 20:16 [PATCH] vcbuild: fix library name for expat with make MSVC=1 Orgad Shaneh via GitGitGadget
2020-09-03  0:06 ` Jonathan Nieder
2020-09-03  2:07   ` Junio C Hamano
2020-09-03  1:42 ` Johannes Schindelin

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://7fh6tueqddpjyxjmgtdiueylzoqt6pt7hec3pukyptlmohoowvhde4yd.onion/inbox.comp.version-control.git
	nntp://ie5yzdi7fg72h7s4sdcztq5evakq23rdt33mfyfcddc5u3ndnw24ogqd.onion/inbox.comp.version-control.git
	nntp://4uok3hntl7oi7b4uf4rtfwefqeexfzil2w6kgk2jn5z2f764irre7byd.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git