From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Orgad Shaneh <orgads@gmail.com>,
Orgad Shaneh <orgads@gmail.com>
Subject: Re: [PATCH] vcbuild: fix library name for expat with make MSVC=1
Date: Thu, 3 Sep 2020 03:42:19 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2009030341540.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <pull.722.git.1599077798953.gitgitgadget@gmail.com>
Hi Orgad,
On Wed, 2 Sep 2020, Orgad Shaneh via GitGitGadget wrote:
> From: Orgad Shaneh <orgads@gmail.com>
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
> vcbuild: fix library name for expat with make MSVC=1
>
> Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]
As can be seen at
https://dev.azure.com/git/git/_build/results?buildId=2065&view=artifacts&type=publishedArtifacts,
this change is correct.
ACK.
Thank you,
Dscho
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-722%2Forgads%2Fvcbuild-expat-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-722/orgads/vcbuild-expat-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/722
>
> compat/vcbuild/scripts/clink.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/vcbuild/scripts/clink.pl b/compat/vcbuild/scripts/clink.pl
> index 61ad084a7b..df167d1e1a 100755
> --- a/compat/vcbuild/scripts/clink.pl
> +++ b/compat/vcbuild/scripts/clink.pl
> @@ -66,7 +66,7 @@
> }
> push(@args, $lib);
> } elsif ("$arg" eq "-lexpat") {
> - push(@args, "expat.lib");
> + push(@args, "libexpat.lib");
> } elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
> $arg =~ s/^-L/-LIBPATH:/;
> push(@lflags, $arg);
>
> base-commit: e19713638985533ce461db072b49112da5bd2042
> --
> gitgitgadget
>
prev parent reply other threads:[~2020-09-03 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 20:16 [PATCH] vcbuild: fix library name for expat with make MSVC=1 Orgad Shaneh via GitGitGadget
2020-09-03 0:06 ` Jonathan Nieder
2020-09-03 2:07 ` Junio C Hamano
2020-09-03 1:42 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2009030341540.56@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).