From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00, DATE_IN_PAST_03_06,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 3A0061F66E for ; Wed, 2 Sep 2020 11:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726268AbgIBL4A (ORCPT ); Wed, 2 Sep 2020 07:56:00 -0400 Received: from mout.gmx.net ([212.227.17.22]:45971 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbgIBLzv (ORCPT ); Wed, 2 Sep 2020 07:55:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599047746; bh=Jgarqf4llV0K/2YEsu1VMkES5S7X/QJKTn12dvdx+PI=; h=X-UI-Sender-Class:Date:From:To:cc:Subject:In-Reply-To:References; b=f5ckn1pVvUQGC9IY4QxfJ0CTAhePaRM+ZxTICWVatc74C0u0akalcruO+f2Z3kGrL n30FhQ02ZhH6yzwYO7sfeF8ikR+Qt/ax/IPJEfkEp1n4Yn68EPvLxWzhxPFrp6jQ+u hug57lwPSsRhK+fs0vVPsWCyl7f7hgEhKLEZ5mEA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [172.18.169.176] ([89.1.214.253]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MoO24-1kxXli0yW8-00ojp7; Wed, 02 Sep 2020 13:55:46 +0200 Date: Wed, 2 Sep 2020 09:06:10 +0200 (CEST) From: Johannes Schindelin X-X-Sender: virtualbox@gitforwindows.org To: Junio C Hamano cc: =?UTF-8?Q?SZEDER_G=C3=A1bor?= , Johannes Schindelin via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH v2 3/3] ci: stop linking built-ins to the dashed versions In-Reply-To: Message-ID: References: <20200825134714.GC25052@szeder.dev> User-Agent: Alpine 2.21.1 (DEB 209 2017-03-23) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Provags-ID: V03:K1:ArQWUBXzlUoed25yu4ax4nXv2PYRjBDbNob5ILFTte8pXsJ40ad vXk4M4pyMnR4S//LtBfGlVz0c9Qwtv/Jl4Gf3pBGMRU/l6dia4cH5cQyvSgQBVhG08TVvK/ SLjhFbOSQ0khsTdtExr++x0izvfuukj96GHEmxxL7ByNbQcG6PAdkIT8gylcd4W4RP6wUtJ LOmrrYE24VXOE7B2UnrDA== X-UI-Out-Filterresults: notjunk:1;V03:K0:G/cCoHZG1F0=:xQLU2V048X4sFLKU143bfl fL8pEIrn7oYtt3I5JR0+o3ALQvqkq7z6GMftHNgxpmDaUn89HDK6HcUcIfBWSpJcKyEaOpV+G /lpulxu+aNCJzRGgtHzVRlzJizt95ZtLcrAQvgJ9hwjctl33LK7EW/R7lS6jrHWXRp6See6yQ M+Fb0E0PEtZ9VpVKibDAO6BQf1+nxIOOvu2k8sm+pdIBAOp3qAjrCRcDnZ8+OCGt1jRDciGd0 nAjNhAuiWJ6HgJfBbgevP3QV9Na/INyLf+q/2Kcjf2ZfHwqwVYQDBK6wxPAGM6TjFaDwRlCk3 sTaZCsv1j+LufmM1i/sz36VZCASQwBXyoHmO1BfUMaNqzwZvFi6SKb9h6fONOF0sAZ+ZFBZUj sp8YdBUzrxwmn1UCz/XshmZe/ZTqte9Ks/fJJlOycddiwq+PAwBpAkK2XNsONajACVB9Yc28A 3faVQKSNVwiGtTPbwhZRr+2G3EwtwUmlrNsZn3FbO62egfNtDlAVf1MU7AQxdEYhbB6y/2lmv 7021KQhY/3VW1AsJGx1+ZVQnQSc8lnjQx1yNEpEh38UrUHqZvAMTpe9/P+B2RdyqrYlatMny9 DjKn8PtkIeHi09ZZMVS+0WmlRm4WIX/+xLXcKX5O7k8t+355M7A9Ez64HxMGbR5cjbT2ESgww QEt7QTBpthIMHdzp3c8/toVVH+addqQIzHPOUkK9PfVxwROjetCWo0e6Gwu1dWuniS0n7IvK5 R0/6o+4U6RUwCATtiMUyltOQEvvhK8WbS1xpcBzgD+p/zxsK21k6bkOtylxMLpASifMTkyHSi GVBRKVjfxghD6wtXgDHn57q571AfDfzgX9jsK9VcPtBmQVgYHDhcPyJ1qGzs2AOGSjKLTYKOj hm/pqD4XDNqLkRxhkxrjv4q5bZpg8fyM+48OtlN4KhXZ4eaZI2l4PTAHd5meAr8Hb6r/4h980 A1WH+JRQhE3RhIqcM/l1lSPCYN7BCgqBBSwLO/fgWYt0HpadKwnF+2Lu1LiX3BFU9Uynk5fq9 01jkD424vpHHpof0z1sGcrBTexyilzWbf0th7CUNyfafAr9GYG1P65zklmE3wj9An7Wyoqxsn Z8LzVFrVHN2zDkpUGpwSi45Yn8435x5y2teT7NFk3OmJA5euqawxPIS7qFBd1BsJWDcbtX36I u3BC+f+5YcaEu55fNPTtjhJtMkTiRzyPXJl08wV4SZ5+UNQj7taSTzzzhvJGv/KGnYrdhb/AE YSQZ2FKVvP0DIbJouXUWV9j++jCgF+/PleEfMpQ== Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Junio, On Wed, 26 Aug 2020, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Actually, `SKIP_DASHED_BUILT_INS` does not _only_ have an impact on `m= ake > > install`: > > ... > > See how `git-add.exe` is linked in the first, but not in the second ru= n? > > OK, that is one more reason why we do want to have 3/3 applied not > for all tasks in the CI , but for subset of tasks that includes the > Windows task. If we had multiple Windows tasks, it may even be > better to have only to some tasks, and allow other tasks build > git-add.exe, so that both can be tested for the primary intended > platform. If you want to skip this patch, that's fine with me. But I would like to clarify what I perceive as a misunderstanding: this patch is not about testing whether it would install the necessary files or not. What this patch does is simply to complete the mission of e4597aae6590 (run test suite without dashed git-commands in PATH, 2009-12-02): to make sure that our very own scripts do not use dashed invocations of built-in commands. In that respect, I find it to make more sense to either do it, or not do it (even if I don't quite understand why we wouldn't do it), instead of doing it only for one platform. Ciao, Dscho