From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ci: stop linking built-ins to the dashed versions
Date: Wed, 26 Aug 2020 06:19:52 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2008260615280.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq364a3f6r.fsf@gitster.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]
Hi,
On Tue, 25 Aug 2020, Junio C Hamano wrote:
> SZEDER Gábor <szeder.dev@gmail.com> writes:
>
> > I'm afraid I don't understand this patch or the previous one (or
> > both?). So this new Makefile knob stops hard-linking the dashed
> > builtins _during 'make install'_, but it doesn't affect how Git is
> > built by the default target. And our CI jobs only build Git by the
> > default target, but don't run 'make install', so setting
> > SKIP_DASHED_BUILT_INS wouldn't have any affect anyway.
>
> Very very true. Let's drop 3/3 if it is not testing anything new.
>
> I do understand the concern 2/3 wants to address, and it would be a
> real one to you especially if you come from Windows. People on the
> platform wouldn't be able to use shell scripts written in 12 years
> ago or written with the promise we made to our users 12 years ago,
> and unlike hardlink-capable platforms it incurs real cost to install
> these individual binaries on disk.
Actually, `SKIP_DASHED_BUILT_INS` does not _only_ have an impact on `make
install`:
$ rm git-add.exe && make
BUILTIN git-add.exe
BUILTIN all
SUBDIR git-gui
SUBDIR gitk-git
SUBDIR templates
$ rm git-add.exe && make SKIP_DASHED_BUILT_INS=1
BUILTIN all
SUBDIR git-gui
SUBDIR gitk-git
SUBDIR templates
See how `git-add.exe` is linked in the first, but not in the second run?
So the difference 3/3 has is that those hard-linked executables are not
even generated. Now, _technically_ this should not result in any change
because we run the test suite without `--with-dashes`.
Practically, it _does_ make a difference, though, as `bin-wrappers/git`
_specifically_ sets `GIT_EXEC_PATH` to the top-level directory, i.e.
`git-add.exe` _would_ be found if any core Git command that is still
implemented as a script called `git-add`.
Therefore, 3/3 makes sure that we really, really, really do not use those
dashed invocations ourselves.
Ciao,
Dscho
next prev parent reply other threads:[~2020-08-26 11:48 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:07 [PATCH 0/3] Optionally skip linking/copying the built-ins Johannes Schindelin
2020-08-17 4:55 ` Johannes Schindelin
2020-08-17 18:02 ` Junio C Hamano
2020-08-24 12:47 ` Johannes Schindelin
2020-08-24 18:42 ` Junio C Hamano
2020-08-25 8:07 ` Johannes Schindelin
2020-08-25 16:03 ` Junio C Hamano
2020-08-17 9:07 ` [PATCH 1/3] msvc: copy the correct `.pdb` files in the Makefile target `install` Johannes Schindelin
2020-08-17 9:24 ` Jeff King
2020-08-17 5:51 ` Johannes Schindelin
2020-08-17 21:37 ` Jeff King
2020-08-18 6:17 ` Johannes Schindelin
2020-08-17 9:07 ` [PATCH 2/3] Optionally skip linking/copying the built-ins Johannes Schindelin
2020-08-17 18:19 ` Junio C Hamano
2020-08-24 14:58 ` Johannes Schindelin
2020-08-17 9:07 ` [PATCH 3/3] ci: stop linking built-ins to the dashed versions Johannes Schindelin
2020-08-17 18:26 ` Junio C Hamano
2020-08-24 15:37 ` [PATCH v2 0/3] Optionally skip linking/copying the built-ins Johannes Schindelin via GitGitGadget
2020-08-24 15:37 ` [PATCH v2 1/3] msvc: copy the correct `.pdb` files in the Makefile target `install` Johannes Schindelin via GitGitGadget
2020-08-24 15:37 ` [PATCH v2 2/3] Optionally skip linking/copying the built-ins Johannes Schindelin via GitGitGadget
2020-08-24 19:02 ` Junio C Hamano
2020-08-25 8:20 ` Johannes Schindelin
2020-08-24 15:38 ` [PATCH v2 3/3] ci: stop linking built-ins to the dashed versions Johannes Schindelin via GitGitGadget
2020-08-24 19:06 ` Junio C Hamano
2020-08-25 8:30 ` Johannes Schindelin
2020-08-25 13:47 ` SZEDER Gábor
2020-08-25 15:42 ` Junio C Hamano
2020-08-26 4:19 ` Johannes Schindelin [this message]
2020-08-26 16:13 ` Junio C Hamano
2020-08-26 16:24 ` Junio C Hamano
2020-09-02 7:06 ` Johannes Schindelin
2020-09-02 20:50 ` Junio C Hamano
2020-08-27 8:30 ` SZEDER Gábor
2020-08-24 18:55 ` [PATCH v2 0/3] Optionally skip linking/copying the built-ins Junio C Hamano
2020-08-24 19:03 ` Jeff King
2020-08-24 19:51 ` Junio C Hamano
2020-08-26 11:56 ` [PATCH v3 " Johannes Schindelin via GitGitGadget
2020-08-26 11:56 ` [PATCH v3 1/3] msvc: copy the correct `.pdb` files in the Makefile target `install` Johannes Schindelin via GitGitGadget
2020-08-26 11:56 ` [PATCH v3 2/3] Optionally skip linking/copying the built-ins Johannes Schindelin via GitGitGadget
2020-08-26 16:20 ` Junio C Hamano
2020-08-26 11:56 ` [PATCH v3 3/3] ci: stop linking built-ins to the dashed versions Johannes Schindelin via GitGitGadget
2020-09-03 10:45 ` SZEDER Gábor
2020-09-08 11:32 ` Johannes Schindelin
2020-09-08 11:48 ` SZEDER Gábor
2020-09-08 17:18 ` Junio C Hamano
2020-09-21 22:28 ` [PATCH v4 0/3] Optionally skip linking/copying the built-ins Johannes Schindelin via GitGitGadget
2020-09-21 22:28 ` [PATCH v4 1/3] msvc: copy the correct `.pdb` files in the Makefile target `install` Johannes Schindelin via GitGitGadget
2020-09-21 22:28 ` [PATCH v4 2/3] Optionally skip linking/copying the built-ins Johannes Schindelin via GitGitGadget
2020-09-21 22:28 ` [PATCH v4 3/3] ci: stop linking built-ins to the dashed versions Johannes Schindelin via GitGitGadget
2020-09-21 22:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2008260615280.56@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).