git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: pw/add-p-allowed-options-fix, was Re: What's cooking in git.git (Aug 2020, #06; Mon, 24)
Date: Tue, 25 Aug 2020 10:58:03 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2008251056290.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq7dtn3785.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, 24 Aug 2020, Junio C Hamano wrote:

> * pw/add-p-allowed-options-fix (2020-08-17) 2 commits
>  - add -p: fix checking of user input
>  - add -p: use ALLOC_GROW_BY instead of ALLOW_GROW
>
>  "git add -p" update.
>
>  Will merge to 'next'.

I thought the consensus was to untangle the refactoring in the second
patch by first fixing the `e` case, and _then_ refactoring?

With Phillip being offline for a couple days, however, I think we can just
go forward with the patches as-are. They are in "good enough" a shape.

Ciao,
Dscho

  reply	other threads:[~2020-08-25 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25  0:22 What's cooking in git.git (Aug 2020, #06; Mon, 24) Junio C Hamano
2020-08-25  8:58 ` Johannes Schindelin [this message]
2020-08-25 15:46   ` pw/add-p-allowed-options-fix, was " Junio C Hamano
2020-08-25 19:42 ` Emily Shaffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.2008251056290.56@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).