From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t5608: avoid say and use skip_all for consistency
Date: Fri, 22 May 2020 15:04:23 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2005221459190.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20200521230510.13077-1-carenas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2455 bytes --]
Hi Carlo,
> Subject : Re: [PATCH] t5608: avoid say and use skip_all for consistency
It might make quite a bit of sense to add a visual indicator to "say" to
make it clear that it is not a verb, but a function name. Otherwise
non-native speakers such as myself (and maybe even native speakers) will
stumble over the grammar of this sentence when trying to parse it.
These would work better for me:
t5608: avoid `say` and use `skip_all` for consistency
or
t5608: avoid say() and use skip_all() for consistency
On Thu, 21 May 2020, Carlo Marcelo Arenas Belón wrote:
> Printing a message directly to stdout could affect TAP processing
> and is not really needed, as there is a standard way to skip all
> tests that could be used instead (including a message).
>
> While at it, update the message to better reflect the use of
> booleans and get rid of the prerequisite.
Makes sense. I would have added a sentence to say that _all_ three test
cases were guarded by the very same prereq, so `skip_all` is just much
faster and idempotent.
Otherwise, the patch looks good to me.
Ciao,
Dscho
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> t/t5608-clone-2gb.sh | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/t/t5608-clone-2gb.sh b/t/t5608-clone-2gb.sh
> index eee0842888..4c476d2fa1 100755
> --- a/t/t5608-clone-2gb.sh
> +++ b/t/t5608-clone-2gb.sh
> @@ -5,12 +5,11 @@ test_description='Test cloning a repository larger than 2 gigabyte'
>
> if ! test_bool_env GIT_TEST_CLONE_2GB false
> then
> - say 'Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t'
> -else
> - test_set_prereq CLONE_2GB
> + skip_all='expensive 2GB clone test; enable with GIT_TEST_CLONE_2GB=true'
> + test_done
> fi
>
> -test_expect_success CLONE_2GB 'setup' '
> +test_expect_success 'setup' '
>
> git config pack.compression 0 &&
> git config pack.depth 0 &&
> @@ -38,13 +37,13 @@ test_expect_success CLONE_2GB 'setup' '
>
> '
>
> -test_expect_success CLONE_2GB 'clone - bare' '
> +test_expect_success 'clone - bare' '
>
> git clone --bare --no-hardlinks . clone-bare
>
> '
>
> -test_expect_success CLONE_2GB 'clone - with worktree, file:// protocol' '
> +test_expect_success 'clone - with worktree, file:// protocol' '
>
> git clone "file://$(pwd)" clone-wt
>
> --
> 2.27.0.rc1.181.g8d5cacc8d1
>
>
next prev parent reply other threads:[~2020-05-22 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 23:05 [PATCH] t5608: avoid say and use skip_all for consistency Carlo Marcelo Arenas Belón
2020-05-22 13:04 ` Johannes Schindelin [this message]
2020-05-24 16:16 ` Junio C Hamano
2020-05-22 18:42 ` [PATCH v2] t5608: avoid say() and use "skip_all" instead " Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2005221459190.56@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).