From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: "Martin Ågren" <martin.agren@gmail.com> Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>, Git Mailing List <git@vger.kernel.org>, Nathan Sanders <spekbukkem@gmail.com> Subject: Re: [PATCH] mingw: cope with the Isilon network file system Date: Thu, 9 Apr 2020 14:02:42 +0200 (CEST) [thread overview] Message-ID: <nycvar.QRO.7.76.6.2004091356110.46@tvgsbejvaqbjf.bet> (raw) In-Reply-To: <CAN0heSrvZb3z3JdYSXs4Dy4nBwPYBAQZ5Zf2f9RSeUnyQSLeeg@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 2338 bytes --] Hi Martin, On Thu, 9 Apr 2020, Martin Ågren wrote: > On Thu, 9 Apr 2020 at 12:26, Johannes Schindelin via GitGitGadget > <gitgitgadget@gmail.com> wrote: > > > handle = CreateFileW(wfilename, FILE_APPEND_DATA, > > FILE_SHARE_WRITE | FILE_SHARE_READ, > > NULL, create, FILE_ATTRIBUTE_NORMAL, NULL); > > - if (handle == INVALID_HANDLE_VALUE) > > - return errno = err_win_to_posix(GetLastError()), -1; > > (This code, which is being removed, used "," to avoid having to introduce > braces. There's another instance of this pattern a bit above.) Oh yes, that's an important point I had missed. > > + if (handle == INVALID_HANDLE_VALUE) { > > (Adding a brace here.) > > > + DWORD err = GetLastError(); > > + /* > > + * Some network storage solutions (e.g. Isilon) might return > > + * ERROR_INVALID_PARAMETER instead of expected error > > + * ERROR_PATH_NOT_FOUND, which results in a unknow error. If > > s/ a / an / > s/unknow/&n/ Oh shucks. Usually I try to do a final review of the patches before I "upstream" them. Seems like the quality of my submission here is not what I want it to be. > > > + * so, the error is now forced to be an ERROR_PATH_NOT_FOUND > > + * error instead. > > + */ > > "is now forced" sounds more like it describes this change/commit, rather > than this piece of code. Maybe this final sentence can be scrapped > entirely, since the forcing/translating/mapping is obvious from the code > anyway? The remainder of the comment goes into *why* and looks more > useful. Just my 2 cents. > > > + if (err == ERROR_INVALID_PARAMETER) > > + err = ERROR_PATH_NOT_FOUND; > > + return errno = err_win_to_posix(err), -1; > > + } > > Now there's no need to avoid introducing braces, so maybe split this > into two lines for a lower huh-factor? > > errno = err_win_to_posix(err); > return -1; Absolutely. I updated the PR at https://github.com/git/git/pull/756 (also addressing issues with the commit message) and will wait for while before sending v2. Thank you for your excellent review, Dscho
next prev parent reply other threads:[~2020-04-09 12:02 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-09 10:24 Johannes Schindelin via GitGitGadget 2020-04-09 10:57 ` Martin Ågren 2020-04-09 12:02 ` Johannes Schindelin [this message] 2020-04-10 11:28 ` [PATCH v2] " Johannes Schindelin via GitGitGadget 2020-04-10 20:21 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=nycvar.QRO.7.76.6.2004091356110.46@tvgsbejvaqbjf.bet \ --to=johannes.schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=gitgitgadget@gmail.com \ --cc=martin.agren@gmail.com \ --cc=spekbukkem@gmail.com \ --subject='Re: [PATCH] mingw: cope with the Isilon network file system' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).