From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Heba Waly <heba.waly@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Heba Waly via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [PATCH v2 1/1] branch: advise the user to checkout a different branch before deleting
Date: Wed, 8 Jan 2020 20:01:12 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2001081945490.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <CACg5j260h88bd=W_4EzAn7B0TiU02Y8BzKDQ7w3UJiHkhL60NQ@mail.gmail.com>
Hi,
On Thu, 9 Jan 2020, Heba Waly wrote:
> On Wed, Jan 8, 2020 at 10:28 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> > advice seems simple on the surface, but every new piece of advice
> > means having to add yet another configuration variable, writing more
> > code, more tests, and more documentation
FWIW I disagree that we need to reduce the number of config settings.
Pretty much all of them have a good reason to exist.
I _could_ however see some sort of categorisation as a valuable goal,
which would potentially make it easier to have chapters in the `git
config` documentation where earlier chapters describe common settings
and the later chapters describe subsequently more obscure settings.
> This raises a question though, do we really need a new configuration for
> every new advice?
I would keep it this way, if only for consistency (a department in which
Git still has a lot of room for improvement).
> So a user who's not interested in receiving advice will have to
> disable every single advice config? It doesn't seem scalable to me.
> I imagine a user will either want to enable or disable the advice
> feature all together. Why don't we have only one `enable_advice`
> configuration that controls all the advice messages?
This is the first time I hear about anybody wanting to disable any advice
;-)
If this is desired, it should be easy enough:
-- snip --
diff --git a/advice.c b/advice.c
index 3ee0ee2d8fb..28e48d5410b 100644
--- a/advice.c
+++ b/advice.c
@@ -138,6 +138,13 @@ int git_default_advice_config(const char *var, const char *value)
if (!skip_prefix(var, "advice.", &k))
return 0;
+ if (!strcmp(k, "suppressall")) {
+ if (git_config_bool(var, value))
+ for (i = 0; i < ARRAY_SIZE(advice_config); i++)
+ *advice_config[i].preference = 0;
+ return 0;
+ }
+
for (i = 0; i < ARRAY_SIZE(advice_config); i++) {
if (strcasecmp(k, advice_config[i].name))
continue;
-- snap --
I don't really think that this is desired, though. Git has earned a
reputation for being hard to use, so I was personally delighted when we
started introducing the advise feature, and I have actually heard a couple
users say good things whenever Git learns to help them without having to
ask another human being (and feeling dumb as a consequence).
Ciao,
Dscho
next prev parent reply other threads:[~2020-01-08 19:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 2:49 [PATCH 0/1] [Outreachy] [RFC] branch: advise the user to checkout a different branch before deleting Heba Waly via GitGitGadget
2020-01-02 2:49 ` [PATCH 1/1] " Heba Waly via GitGitGadget
2020-01-02 8:18 ` Eric Sunshine
2020-01-06 0:42 ` Heba Waly
2020-01-07 4:10 ` [PATCH v2 0/1] [Outreachy] [RFC] " Heba Waly via GitGitGadget
2020-01-07 4:10 ` [PATCH v2 1/1] " Heba Waly via GitGitGadget
2020-01-07 11:16 ` Eric Sunshine
2020-01-07 16:34 ` Junio C Hamano
2020-01-08 1:44 ` Emily Shaffer
2020-01-08 10:22 ` Eric Sunshine
2020-01-08 1:14 ` Heba Waly
2020-01-08 9:27 ` Eric Sunshine
2020-01-08 18:06 ` Heba Waly
2020-01-08 19:01 ` Johannes Schindelin [this message]
2020-01-08 19:15 ` Junio C Hamano
2020-01-10 12:11 ` Heba Waly
2020-01-08 19:05 ` Junio C Hamano
2020-01-10 12:09 ` Heba Waly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2001081945490.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=heba.waly@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).