From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/1] mingw: only test index entries for backslashes, not tree entries
Date: Thu, 2 Jan 2020 20:53:16 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2001022051410.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqk16dfpcy.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 30 Dec 2019, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Turns out that this inconsistency is only in Git for Windows v2.24.1(2)
> > but not in current `master` of Git, so I simply struck that part from the
> > commit message.
> > ...
> > I rephrased it to:
> >
> > So let's loosen the requirements: we now leave tree entries with
> > backslashes in their file names alone, but we do require any entries
> > that are added to the Git index to contain no backslashes on Windows.
> > ...
>
> We are in -rc so there is no real rush,
My intention was actually to integrate this patch into Git for Windows
v2.25.0-rc1 already, that's why I sent it out for review even this late in
the -rc phase.
> but I take these to mean that I should just leave this loose end hanging
> untied, and wait for an updated version to replace it sometime early
> next year.
I sent out a new iteration of the patch *just* before the new year arrived
over here ;-)
> Thanks and happy new year.
The same to you!
Dscho
next prev parent reply other threads:[~2020-01-02 19:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 17:42 [PATCH 0/1] Disallow writing, but not fetching commits with file names containing backslashes Johannes Schindelin via GitGitGadget
2019-12-26 17:42 ` [PATCH 1/1] mingw: only test index entries for backslashes, not tree entries Johannes Schindelin via GitGitGadget
2019-12-26 18:56 ` Junio C Hamano
2019-12-26 21:16 ` Johannes Schindelin
2019-12-30 21:57 ` Junio C Hamano
2020-01-02 19:53 ` Johannes Schindelin [this message]
2019-12-26 20:03 ` Jonathan Nieder
2019-12-26 21:23 ` Johannes Schindelin
2019-12-26 21:42 ` Jonathan Nieder
2019-12-26 22:01 ` Junio C Hamano
2019-12-26 22:25 ` Junio C Hamano
2019-12-31 22:51 ` Johannes Schindelin
2020-01-02 19:58 ` Johannes Schindelin
2020-01-04 1:57 ` Jonathan Nieder
2020-01-04 21:29 ` Johannes Schindelin
2019-12-26 19:22 ` [PATCH 0/1] Disallow writing, but not fetching commits with file names containing backslashes Junio C Hamano
2019-12-26 21:19 ` Johannes Schindelin
2019-12-31 22:53 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2019-12-31 22:53 ` [PATCH v2 1/1] mingw: only test index entries for backslashes, not tree entries Johannes Schindelin via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2001022051410.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).