From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles
Date: Tue, 3 Dec 2019 13:04:45 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1912031303250.31080@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <a4ac4530-9b5c-3eb6-ada2-067c6ef73868@kdbg.org>
Hi Hannes,
On Mon, 2 Dec 2019, Johannes Sixt wrote:
> Am 02.12.19 um 12:33 schrieb Johannes Schindelin via GitGitGadget:
> > Range-diff vs v2:
> >
> > 1: 280b6d08a4 = 1: 280b6d08a4 mingw: do set `errno` correctly when trying to restrict handle inheritance
> > 2: c3dea00fb1 ! 2: e04e1269b3 mingw: translate ERROR_SUCCESS to errno = 0
> > @@ -3,12 +3,15 @@
> > mingw: translate ERROR_SUCCESS to errno = 0
>
> The subject line would have to be adjusted as well.
>
> mingw: forbid translating ERROR_SUCCESS to an errno value
>
> or something.
Oy. Thank you for catching this! (It is always amazing to me how much I
miss when I have stared at the same commits for a while.)
For good measure, I force-pushed the branch of the PR to match what Junio
has in `pu`, but if there are no other changes I need to make, I will
refrain from submitting another iteration.
Thanks,
Dscho
>
> >
> > Johannes Sixt pointed out that the `err_win_to_posix()` function
> > - mishandles `ERROR_SUCCESS`. This commit fixes that.
> > + mishandles `ERROR_SUCCESS`: it maps it to `ENOSYS`.
> >
> > - Technically, we try to only assign `errno` to the corresponding value of
> > - `GetLastError()` (which translation is performed by that function) when
> > - a Win32 API call failed, so this change is purely defensive and is not
> > - expected to fix an existing bug in our code base.
> > + The only purpose of this function is to map Win32 API errors to `errno`
> > + ones, and there is actually no equivalent to `ERROR_SUCCESS`: the idea
> > + of `errno` is that it will only be set in case of an error, and left
> > + alone in case of success.
> > +
> > + Therefore, as pointed out by Junio Hamano, it is a bug to call this
> > + function when there was not even any error to map.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > @@ -19,7 +22,7 @@
> > case ERROR_SHARING_BUFFER_EXCEEDED: error = ENFILE; break;
> > case ERROR_SHARING_VIOLATION: error = EACCES; break;
> > case ERROR_STACK_OVERFLOW: error = ENOMEM; break;
> > -+ case ERROR_SUCCESS: error = 0; break;
> > ++ case ERROR_SUCCESS: BUG("err_win_to_posix() called without an error!");
> > case ERROR_SWAPERROR: error = ENOENT; break;
> > case ERROR_TOO_MANY_MODULES: error = EMFILE; break;
> > case ERROR_TOO_MANY_OPEN_FILES: error = EMFILE; break;
> >
>
> -- Hannes
>
prev parent reply other threads:[~2019-12-03 12:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 21:44 [PATCH 0/1] Brown-bag fix on top of js/mingw-inherit-only-std-handles Johannes Schindelin via GitGitGadget
2019-11-29 21:44 ` [PATCH 1/1] mingw: do set `errno` correctly when trying to restrict handle inheritance Johannes Schindelin via GitGitGadget
2019-11-29 23:02 ` Johannes Sixt
2019-11-30 22:06 ` Johannes Schindelin
2019-11-30 22:16 ` Johannes Sixt
2019-11-30 10:36 ` [PATCH v2 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles Johannes Schindelin via GitGitGadget
2019-11-30 10:36 ` [PATCH v2 1/2] mingw: do set `errno` correctly when trying to restrict handle inheritance Johannes Schindelin via GitGitGadget
2019-11-30 10:36 ` [PATCH v2 2/2] mingw: translate ERROR_SUCCESS to errno = 0 Johannes Schindelin via GitGitGadget
2019-11-30 18:04 ` [PATCH v2 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles Junio C Hamano
2019-11-30 19:13 ` Johannes Sixt
2019-11-30 20:11 ` Andreas Schwab
2019-11-30 20:23 ` Junio C Hamano
2019-11-30 20:43 ` Andreas Schwab
2019-11-30 21:22 ` Johannes Schindelin
2019-11-30 20:21 ` Junio C Hamano
2019-12-01 6:26 ` Junio C Hamano
2019-12-01 9:53 ` Johannes Schindelin
2019-12-02 6:07 ` Junio C Hamano
2019-12-02 9:05 ` Johannes Schindelin
2019-11-30 19:20 ` Johannes Sixt
2019-11-30 22:09 ` Junio C Hamano
2019-12-02 11:33 ` [PATCH v3 " Johannes Schindelin via GitGitGadget
2019-12-02 11:33 ` [PATCH v3 1/2] mingw: do set `errno` correctly when trying to restrict handle inheritance Johannes Schindelin via GitGitGadget
2019-12-02 11:33 ` [PATCH v3 2/2] mingw: translate ERROR_SUCCESS to errno = 0 Johannes Schindelin via GitGitGadget
2019-12-02 17:35 ` [PATCH v3 0/2] Brown-bag fix on top of js/mingw-inherit-only-std-handles Johannes Sixt
2019-12-02 19:04 ` Junio C Hamano
2019-12-03 12:04 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1912031303250.31080@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).