git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/1] pkt-line: fix a typo
Date: Mon, 2 Dec 2019 18:02:12 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1912021801350.31080@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqr21myfrz.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Mon, 2 Dec 2019, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > This typo was introduced in 2153d478b74 (pkt-line: introduce
> > packet_read_with_status, 2018-03-14).
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
>
> Good eyes.  Will queue.  Thanks.

Heh, as much as I would love to take credit for spotting it, it was
actually cSpell in Visual Studio Code that spotted it ;-)

Ciao,
Dscho

>
> >  pkt-line.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/pkt-line.h b/pkt-line.h
> > index 5c62015db4..fef3a0d792 100644
> > --- a/pkt-line.h
> > +++ b/pkt-line.h
> > @@ -77,7 +77,7 @@ int packet_read(int fd, char **src_buffer, size_t *src_len, char
> >  /*
> >   * Read a packetized line into a buffer like the 'packet_read()' function but
> >   * returns an 'enum packet_read_status' which indicates the status of the read.
> > - * The number of bytes read will be assigined to *pktlen if the status of the
> > + * The number of bytes read will be assigned to *pktlen if the status of the
> >   * read was 'PACKET_READ_NORMAL'.
> >   */
> >  enum packet_read_status {
>

      reply	other threads:[~2019-12-02 17:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  8:43 [PATCH 0/1] pkt-line: fix a typo Johannes Schindelin via GitGitGadget
2019-12-02  8:43 ` [PATCH 1/1] " Johannes Schindelin via GitGitGadget
2019-12-02 14:16   ` Junio C Hamano
2019-12-02 17:02     ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1912021801350.31080@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).