git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nika Layzell via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Nika Layzell <nika@thelayzells.com>
Subject: Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode
Date: Mon, 25 Nov 2019 15:45:53 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1911251543430.31080@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1911251523530.31080@tvgsbejvaqbjf.bet>

Hi Junio,

On Mon, 25 Nov 2019, Johannes Schindelin wrote:

> On Sun, 24 Nov 2019, Junio C Hamano wrote:
>
> > "Nika Layzell via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >
> > > The refresh command is called from git-add--interactive to ensure that git's
> > > view of the worktree is up-to-date. This is necessary for most commands
> > > which use git-add--interactive, as they are interacting with the worktree,
> > > however it's not necessary for git-reset, which exclusively operates on the
> > > index. This patch skips the refresh call when performing a git-reset -p,
> > > which can improve performance on large repositories which have out-of-date,
> > > or no, caches of the current worktree state.
> > >
> > > I chose to use the existing FILTER property of the flavour to make this
> > > decision. A separate REFRESH property could be added instead.
> >
> > Hmph, I wonder why this was sent my way.  How does GGG determine
> > whom to send patches to?  I, like other reviewers, prefer not to see
> > earlier rounds of patches sent directly to me unless they are about
> > areas that I am mostly responsible for (other patches I'll see them
> > and review them on the copies sent to the mailing list anyway).

Oops, I forgot to address this. The reason why this is sent your way is
that you are the Git maintainer, and as such, GitGitGadget sends _all_ Git
patches your way (except the Git GUI ones).

The reason for this is that this is the suggested way, as per
https://git-scm.com/docs/SubmittingPatches#patch-flow:

> 5. The list forms consensus that the last round of your patch is good. Send
>    it to the maintainer and cc the list.

Ciao,
Dscho

> > CC'ing Dscho who has stakes in keeping the scripted "add -i" frozen,
> > while he is rewriting it in C.
>
> Thanks for pinging me!
>
> As it were, I was aware of this effort, and I am quite happy about it (and
> of course I will adjust my patch series accordingly).
>
> Thank you,
> Dscho
>
> >
> > Thanks.
> >
> > >
> > > Nika Layzell (1):
> > >   add--interactive: skip index refresh in reset patch mode
> > >
> > >  git-add--interactive.perl | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > >
> > > base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
> > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-475%2Fmystor%2Findex-only-refresh-v1
> > > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-475/mystor/index-only-refresh-v1
> > > Pull-Request: https://github.com/gitgitgadget/git/pull/475
> >
>

  reply	other threads:[~2019-11-25 14:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 19:56 [PATCH 0/1] add--interactive: skip index refresh in reset patch mode Nika Layzell via GitGitGadget
2019-11-23 19:56 ` [PATCH 1/1] " Nika Layzell via GitGitGadget
2019-11-24  6:01 ` [PATCH 0/1] " Junio C Hamano
2019-11-25 14:24   ` Johannes Schindelin
2019-11-25 14:45     ` Johannes Schindelin [this message]
2019-11-26  1:13       ` Junio C Hamano
2021-01-07 14:18         ` Cc'ing the Git maintainer on GitGitGadget contributions, was " Johannes Schindelin
2021-01-07 14:57           ` Ævar Arnfjörð Bjarmason
2021-01-07 16:20             ` Johannes Schindelin
2021-01-07 21:25               ` Junio C Hamano
2021-01-08 14:56                 ` Johannes Schindelin
2021-01-08 19:48                   ` Junio C Hamano
2021-01-10 12:02                     ` Johannes Schindelin
2021-01-08 20:08                   ` Taylor Blau
2021-01-10 12:21                     ` Johannes Schindelin
2021-01-10 20:18                       ` Junio C Hamano
2021-01-11 19:18                         ` Taylor Blau
2021-01-12 23:22                           ` Junio C Hamano
2021-01-14  6:32                         ` 胡哲宁
2019-11-26  1:12     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1911251543430.31080@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=nika@thelayzells.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).