From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] xdiffi: fix typos and touch up comments
Date: Thu, 10 Oct 2019 13:58:30 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1910101358020.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20191009203847.GB7007@sigill.intra.peff.net>
Hi Peff,
On Wed, 9 Oct 2019, Jeff King wrote:
> On Tue, Oct 08, 2019 at 11:27:52AM -0700, Johannes Schindelin via GitGitGadget wrote:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Inspired by the thoroughly stale https://github.com/git/git/pull/159,
> > this patch fixes a couple of typos, rewraps and clarifies some comments.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > xdiff/xdiffi.c | 99 ++++++++++++++++++++++++++++----------------------
> > 1 file changed, 55 insertions(+), 44 deletions(-)
>
> I scanned through these with diff-highlight, and they all look good to
> me!
Thank you!
Dscho
P.S.: Darn, now I really have to find time to check out
diff-highlight...
prev parent reply other threads:[~2019-10-10 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 18:27 [PATCH 0/1] xdiffi: fix typos and touch up comments Johannes Schindelin via GitGitGadget
2019-10-08 18:27 ` [PATCH 1/1] " Johannes Schindelin via GitGitGadget
2019-10-09 20:38 ` Jeff King
2019-10-10 11:58 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1910101358020.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).