git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Cameron Steffen via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Cameron Steffen <cam.steffen94@gmail.com>
Subject: Re: [PATCH 1/1] doc: small formatting fix
Date: Wed, 11 Sep 2019 23:24:32 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1909112322220.5377@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <5248e3332c90e91c1c6a911090d331f005789014.1568071262.git.gitgitgadget@gmail.com>

Hi Cameron,

On Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote:

> From: Cameron Steffen <cam.steffen94@gmail.com>
>
> move an incorrectly placed backtick

This sentence is incomplete, and does not really explain _why_ the
backtick needs to be moved. Something like this would be much clearer:

	Most likely by mistake, the closing curly brace was added
	_after_ the backtick instead of _before_ it. This breaks the
	formatting. Let's fix that.

The patch looks good, though.

To send another iteration of this patch, amend your commit locally,
force-push, and issue another `/submit`.

Ciao,
Johannes

>
> Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>
> ---
>  Documentation/pretty-formats.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index 079598307a..b87e2e83e6 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -208,7 +208,7 @@ endif::git-rev-list[]
>  '%GP':: show the fingerprint of the primary key whose subkey was used
>  	to sign a signed commit
>  '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2
> -	minutes ago`}; the format follows the rules described for the
> +	minutes ago}`; the format follows the rules described for the
>  	`-g` option. The portion before the `@` is the refname as
>  	given on the command line (so `git log -g refs/heads/master`
>  	would yield `refs/heads/master@{0}`).
> --
> gitgitgadget
>

  parent reply	other threads:[~2019-09-11 21:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 23:21 [PATCH 0/1] doc: small formatting fix Cameron Steffen via GitGitGadget
2019-09-09 23:21 ` [PATCH 1/1] " Cameron Steffen via GitGitGadget
2019-09-11 11:50   ` Derrick Stolee
2019-09-11 21:24   ` Johannes Schindelin [this message]
2019-09-11 11:49 ` [PATCH 0/1] " Derrick Stolee
2019-09-11 14:52 ` [PATCH v2 " Cameron Steffen via GitGitGadget
2019-09-11 14:52   ` [PATCH v2 1/1] doc: minor " Cameron Steffen via GitGitGadget
2019-09-12 18:06     ` Junio C Hamano
2019-09-11 21:21 ` [PATCH 0/1] doc: small " Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1909112322220.5377@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=cam.steffen94@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).