From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] parseopt: move definition of enum parse_opt_result up
Date: Thu, 22 Aug 2019 16:47:01 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1908221646460.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <58e5dd7b-d577-a1d9-c704-44642f553323@web.de>
[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]
Hi,
On Tue, 20 Aug 2019, René Scharfe wrote:
> Define enum parse_opt_result before using it in a typedef. This avoids
> the following compiler warning:
>
> ./parse-options.h:53:14: error: ISO C forbids forward references to 'enum' types [-Werror,-Wpedantic]
> typedef enum parse_opt_result parse_opt_ll_cb(struct parse_opt_ctx_t *ctx,
> ^
>
> While GCC and Clang both accept such a forward reference by default,
> other compilers might be less forgiving.
Looks obviously correct to me.
Thanks,
Dscho
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> parse-options.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/parse-options.h b/parse-options.h
> index a4bd40bb6a..38a33a087e 100644
> --- a/parse-options.h
> +++ b/parse-options.h
> @@ -46,6 +46,15 @@ enum parse_opt_option_flags {
> PARSE_OPT_COMP_ARG = 1024
> };
>
> +enum parse_opt_result {
> + PARSE_OPT_COMPLETE = -3,
> + PARSE_OPT_HELP = -2,
> + PARSE_OPT_ERROR = -1, /* must be the same as error() */
> + PARSE_OPT_DONE = 0, /* fixed so that "return 0" works */
> + PARSE_OPT_NON_OPTION,
> + PARSE_OPT_UNKNOWN
> +};
> +
> struct option;
> typedef int parse_opt_cb(const struct option *, const char *arg, int unset);
>
> @@ -241,15 +250,6 @@ const char *optname(const struct option *opt, int flags);
>
> /*----- incremental advanced APIs -----*/
>
> -enum parse_opt_result {
> - PARSE_OPT_COMPLETE = -3,
> - PARSE_OPT_HELP = -2,
> - PARSE_OPT_ERROR = -1, /* must be the same as error() */
> - PARSE_OPT_DONE = 0, /* fixed so that "return 0" works */
> - PARSE_OPT_NON_OPTION,
> - PARSE_OPT_UNKNOWN
> -};
> -
> /*
> * It's okay for the caller to consume argv/argc in the usual way.
> * Other fields of that structure are private to parse-options and should not
> --
> 2.23.0
>
prev parent reply other threads:[~2019-08-22 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 18:49 [PATCH] parseopt: move definition of enum parse_opt_result up René Scharfe
2019-08-22 14:47 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1908221646460.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).