From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: "SZEDER Gábor" <firstname.lastname@example.org> Cc: Junio C Hamano <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH] test-lib-functions: show the test name at the start of verbose output Date: Mon, 5 Aug 2019 13:32:12 +0200 (CEST) [thread overview] Message-ID: <nycvar.QRO.email@example.com> (raw) In-Reply-To: <20190805101237.GA20404@szeder.dev> [-- Attachment #1: Type: text/plain, Size: 1688 bytes --] Hi Gábor, On Mon, 5 Aug 2019, SZEDER Gábor wrote: > On Sun, Aug 04, 2019 at 09:14:46PM +0200, Johannes Schindelin wrote: > > > > On Sat, 3 Aug 2019, SZEDER Gábor wrote: > > > > > So the dummy test above would start like this: > > > > > > expecting success of 'commit works': > > > echo content >file && > > > [...] > > > > Maybe it would make sense to also mention the test and test case number, > > like so? > > > > expecting success of t9876.54 'it works': > > It's easy enough to do so, but I don't readily see any benefits. > > The '--verbose-log' of each test script is written to a separate > file, whose name already contains the test number, so there is no use > including it for each test case in there. When running a test script > and looking at its '--verbose' output, then surely all test numbers > must be from that particular test script, so there is no use, either. > > As for the test case number, since the test cases are not numbered in > the test scripts, I just ignore them right away, and look for test > names anyway. > > Could you give an example? Oh, my common way to read test logs is to sift through CI builds' logs, in particular for the branches on https://github.com/gitster/git that are based on commits without support for the convenient Tests tab in Azure Pipelines. So I hit Ctrl+F and look for `not ok` in literally hundreds/thousands of lines. Of course, this is already the unrolled log _only_ of the failed test scripts. Still, it is no fun to scoll back from test case 64 all the way to 1 just to find out which test script contains this particular failed test case. Ciao, Dscho
next prev parent reply other threads:[~2019-08-05 11:32 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-03 8:01 SZEDER Gábor 2019-08-04 19:14 ` Johannes Schindelin 2019-08-05 10:12 ` SZEDER Gábor 2019-08-05 11:32 ` Johannes Schindelin [this message] 2019-08-05 21:04 ` [PATCH v2 0/2] tests: show the test name and number " SZEDER Gábor 2019-08-05 21:04 ` [PATCH v2 1/2] t0000-basic: use realistic test script names in the verbose tests SZEDER Gábor 2019-08-05 21:04 ` [PATCH v2 2/2] tests: show the test name and number at the start of verbose output SZEDER Gábor 2019-08-08 20:12 ` [PATCH v2 0/2] " Johannes Schindelin 2019-08-08 22:09 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=nycvar.QRO.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] test-lib-functions: show the test name at the start of verbose output' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).